From 06a03c972b04159a6ae57cd9e4959eaa1d164d7b Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Tue, 2 Jan 2018 13:43:21 +0100 Subject: apt.daily: remove unused dbus signal for apt update MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The signal was introduced with the introduction of the script itself, but seems to have never got any user as all references to it I can find are references to other code appearing in the cronjob. It is also the wrong place nowadays as the cronjob is just one place an update can be triggered by, so if notifications about an update being run are desired it is better to use a hook which will be called by all update calls (script, cron, user, …). Removing this code solves also the problem of improving the check to avoid running into problems with security systems like SELinux. References: 0c1326826fd23ce859db8e923c37b7199c6da2c8 Closes: 849636 --- debian/apt.systemd.daily | 9 --------- 1 file changed, 9 deletions(-) diff --git a/debian/apt.systemd.daily b/debian/apt.systemd.daily index 40b6692ec..c4f3c24f0 100755 --- a/debian/apt.systemd.daily +++ b/debian/apt.systemd.daily @@ -445,15 +445,6 @@ if [ "$1" = "update" -o -z "$1" ] ; then if check_stamp $UPDATE_STAMP $UpdateInterval; then if eval apt-get $XAPTOPT -y update $XSTDERR; then debug_echo "download updated metadata (success)." - if which dbus-send >/dev/null 2>&1 && pidof dbus-daemon >/dev/null 2>&1; then - if dbus-send --system / app.apt.dbus.updated boolean:true ; then - debug_echo "send dbus signal (success)" - else - debug_echo "send dbus signal (error)" - fi - else - debug_echo "dbus signal not send (command not available)" - fi update_stamp $UPDATE_STAMP UPDATED=1 else -- cgit v1.2.3