From a66e1837812cefc1f08788f8696724d4931e8022 Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Tue, 16 Feb 2016 16:02:46 +0100 Subject: tests: expect no output while compiling noopchroot This way we hopefully notice (new) warnings in this little helper. Git-Dch: Ignore --- test/integration/framework | 10 +++++++--- test/integration/test-external-dependency-solver-protocol | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/test/integration/framework b/test/integration/framework index a1523467d..a0eeb6d45 100644 --- a/test/integration/framework +++ b/test/integration/framework @@ -517,7 +517,7 @@ int execvp(const char *file, char *const argv[]) { return func_execvp(newfile, argv); } EOF - testsuccess --nomsg gcc -Wall -fPIC -shared -o noopchroot.so noopchroot.c -ldl + testempty --nomsg gcc -Wall -Wextra -fPIC -shared -o noopchroot.so noopchroot.c -ldl } configcompression() { local CMD='apthelper cat-file -C' @@ -1313,9 +1313,13 @@ testfileequal() { testempty() { msggroup 'testempty' - msgtest "Test for no output of" "$*" + if [ "$1" = '--nomsg' ]; then + shift + else + msgtest "Test for no output of" "$*" + fi local COMPAREFILE="${TMPWORKINGDIRECTORY}/rootdir/tmp/testempty.comparefile" - if ("$@" >"$COMPAREFILE" 2>&1 || true) && test ! -s "$COMPAREFILE"; then + if "$@" >"$COMPAREFILE" 2>&1 && test ! -s "$COMPAREFILE"; then msgpass else msgfailoutput '' "$COMPAREFILE" "$@" diff --git a/test/integration/test-external-dependency-solver-protocol b/test/integration/test-external-dependency-solver-protocol index 54b58301f..32c5fc354 100755 --- a/test/integration/test-external-dependency-solver-protocol +++ b/test/integration/test-external-dependency-solver-protocol @@ -124,7 +124,7 @@ rm -f "$APT_EDSP_DUMP_FILENAME" testfailure aptget install --solver dump awesomecoolstuff:i386 -s testsuccess test -s "$APT_EDSP_DUMP_FILENAME" testequal 'Install: awesomecoolstuff:i386' grep :i386 "$APT_EDSP_DUMP_FILENAME" -testempty grep -e ':amd64' -e 'Architecture: any' "$APT_EDSP_DUMP_FILENAME" +testfailure grep -e ':amd64' -e 'Architecture: any' "$APT_EDSP_DUMP_FILENAME" testsuccess aptget dist-upgrade -s testsuccess aptget dist-upgrade -s --solver apt -- cgit v1.2.3