From ea6db08d45e012d577f3081fa2070db9e034add9 Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Mon, 16 Aug 2010 11:38:20 +0200 Subject: * apt-pkg/contrib/strutl.cc: - fix error checking for vsnprintf in its safe variant Spotted by -Wextra: contrib/strutl.cc: In function 'char* safe_snprintf(char*, char*, const char*, ...)': contrib/strutl.cc:1172:14: warning: comparison of unsigned expression < 0 is always false --- apt-pkg/contrib/strutl.cc | 2 +- debian/changelog | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/apt-pkg/contrib/strutl.cc b/apt-pkg/contrib/strutl.cc index ace74cb37..c1844de40 100644 --- a/apt-pkg/contrib/strutl.cc +++ b/apt-pkg/contrib/strutl.cc @@ -1161,7 +1161,7 @@ void strprintf(string &out,const char *format,...) char *safe_snprintf(char *Buffer,char *End,const char *Format,...) { va_list args; - unsigned long Did; + int Did; va_start(args,Format); diff --git a/debian/changelog b/debian/changelog index 671d9844e..23c1218d9 100644 --- a/debian/changelog +++ b/debian/changelog @@ -37,8 +37,10 @@ apt (0.8.0~pre1) UNRELASED; urgency=low - purge packages in 'rc' state, thanks Rogier! (Closes: #150831) * apt-pkg/pkgcache.cc: - fix LongDesc handling in LANG=C environment + * apt-pkg/contrib/strutl.cc: + - fix error checking for vsnprintf in its safe variant - -- David Kalnischkies Fri, 13 Aug 2010 16:40:57 +0200 + -- David Kalnischkies Mon, 16 Aug 2010 11:35:53 +0200 apt (0.7.26~exp12) experimental; urgency=low -- cgit v1.2.3