From b52c6552c44fcb997b0db9f5e9f17b4674dd5359 Mon Sep 17 00:00:00 2001 From: Julian Andres Klode Date: Tue, 30 Apr 2019 12:07:07 +0200 Subject: Add 'explicit' to most single argument constructors This prevents implicit conversions that we do not want, such as having a FileFd* being converted to a debListParser. Two cases are not yet handled because they require changes in code using them: 1. The classes in hashes.h 2. The URI class - this one is used quite a lot --- apt-inst/filelist.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'apt-inst/filelist.h') diff --git a/apt-inst/filelist.h b/apt-inst/filelist.h index 7fe43de63..c5f103d87 100644 --- a/apt-inst/filelist.h +++ b/apt-inst/filelist.h @@ -97,7 +97,7 @@ class pkgFLCache bool AddConfFile(const char *Name,const char *NameEnd, PkgIterator const &Owner,const unsigned char *Sum); - pkgFLCache(DynamicMMap &Map); + explicit pkgFLCache(DynamicMMap &Map); // ~pkgFLCache(); }; @@ -288,7 +288,7 @@ class pkgFLCache::NodeIterator Package *RealPackage() const; NodeIterator() : Nde(0), Type(NdeHash), Owner(0) {}; - NodeIterator(pkgFLCache &Owner) : Nde(Owner.NodeP), Type(NdeHash), Owner(&Owner) {} + explicit NodeIterator(pkgFLCache &Owner) : Nde(Owner.NodeP), Type(NdeHash), Owner(&Owner) {} NodeIterator(pkgFLCache &Owner,Node *Trg) : Nde(Trg), Type(NdeHash), Owner(&Owner) {} NodeIterator(pkgFLCache &Owner,Node *Trg,Package *) : Nde(Trg), Type(NdePkg), Owner(&Owner) {} }; -- cgit v1.2.3