From d59671c9eef322c10abba22b0257fef37979dfd4 Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Sun, 5 Jun 2016 13:05:30 +0200 Subject: refactor EDSP classes for better internal reuse The classes are all marked as hidden, so changing them is no problem ABI wise and will help with introducing protocols similar to EDSP. The change has no observeable behavior difference, its just code juggling. Git-Dch: Ignore --- apt-pkg/edsp/edspsystem.h | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) (limited to 'apt-pkg/edsp/edspsystem.h') diff --git a/apt-pkg/edsp/edspsystem.h b/apt-pkg/edsp/edspsystem.h index aa4298f01..2c429c3d6 100644 --- a/apt-pkg/edsp/edspsystem.h +++ b/apt-pkg/edsp/edspsystem.h @@ -14,6 +14,7 @@ #include #include +#include #include #include @@ -22,28 +23,36 @@ class Configuration; class pkgDepCache; class pkgIndexFile; class pkgPackageManager; -class edspIndex; -class edspSystemPrivate; -class APT_HIDDEN edspSystem : public pkgSystem +class APT_HIDDEN edspLikeSystem : public pkgSystem { - /** \brief dpointer placeholder (for later in case we need it) */ - edspSystemPrivate * const d; - - edspIndex *StatusFile; - - public: +protected: + std::unique_ptr StatusFile; +public: virtual bool Lock() APT_OVERRIDE APT_CONST; virtual bool UnLock(bool NoErrors = false) APT_OVERRIDE APT_CONST; virtual pkgPackageManager *CreatePM(pkgDepCache *Cache) const APT_OVERRIDE APT_CONST; virtual bool Initialize(Configuration &Cnf) APT_OVERRIDE; virtual bool ArchiveSupported(const char *Type) APT_OVERRIDE APT_CONST; virtual signed Score(Configuration const &Cnf) APT_OVERRIDE; - virtual bool AddStatusFiles(std::vector &List) APT_OVERRIDE; virtual bool FindIndex(pkgCache::PkgFileIterator File, pkgIndexFile *&Found) const APT_OVERRIDE; + edspLikeSystem(char const * const Label); + virtual ~edspLikeSystem(); +}; + +class APT_HIDDEN edspSystem : public edspLikeSystem +{ + std::string tempDir; + std::string tempStatesFile; + std::string tempPrefsFile; + +public: + virtual bool Initialize(Configuration &Cnf) APT_OVERRIDE; + virtual bool AddStatusFiles(std::vector &List) APT_OVERRIDE; + edspSystem(); virtual ~edspSystem(); }; -- cgit v1.2.3