From f695e76199a43b7f4d5816e20d18496b6448b833 Mon Sep 17 00:00:00 2001 From: Julian Andres Klode Date: Wed, 16 Mar 2016 16:46:39 +0100 Subject: Report non-transient errors as errors, not as warnings This makes it easier to understand what really is an error and what not. --- apt-pkg/update.cc | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'apt-pkg/update.cc') diff --git a/apt-pkg/update.cc b/apt-pkg/update.cc index 369e85122..ca87c6976 100644 --- a/apt-pkg/update.cc +++ b/apt-pkg/update.cc @@ -73,9 +73,13 @@ bool AcquireUpdate(pkgAcquire &Fetcher, int const PulseInterval, uri.User.clear(); uri.Password.clear(); string descUri = string(uri); - _error->Warning(_("Failed to fetch %s %s"), descUri.c_str(), - (*I)->ErrorText.c_str()); - + // Show an error for non-transient failures, otherwise only warn + if ((*I)->Status == pkgAcquire::Item::StatTransientNetworkError) + _error->Warning(_("Failed to fetch %s %s"), descUri.c_str(), + (*I)->ErrorText.c_str()); + else + _error->Error(_("Failed to fetch %s %s"), descUri.c_str(), + (*I)->ErrorText.c_str()); if ((*I)->Status == pkgAcquire::Item::StatTransientNetworkError) { TransientNetworkFailure = true; -- cgit v1.2.3