From 41d39345bdc31cb9b8be057cd678aa2890830437 Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Mon, 26 Oct 2015 16:50:21 +0100 Subject: deal with --version more centrally Git-Dch: Ignore --- apt-private/private-cmndline.cc | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) (limited to 'apt-private/private-cmndline.cc') diff --git a/apt-private/private-cmndline.cc b/apt-private/private-cmndline.cc index d80168fda..348b698ca 100644 --- a/apt-private/private-cmndline.cc +++ b/apt-private/private-cmndline.cc @@ -362,6 +362,25 @@ std::vector getCommandArgs(APT_CMD const Program, char const /*}}}*/ #undef CmdMatches #undef addArg +static bool ShowCommonHelp(APT_CMD const Binary, CommandLine &CmdL, aptDispatchWithHelp const * Cmds)/*{{{*/ +{ + std::cout << PACKAGE << " " << PACKAGE_VERSION << " (" << COMMON_ARCH << ")" << std::endl; + if (_config->FindB("version") == true && Binary != APT_CMD::APT_GET) + return true; + return ShowHelp(CmdL, Cmds); +} + /*}}}*/ +void ShowHelpListCommands(aptDispatchWithHelp const * Cmds) /*{{{*/ +{ + std::cout << _("Commands:") << std::endl; + for (; Cmds->Handler != nullptr; ++Cmds) + { + if (Cmds->Help == nullptr) + continue; + std::cout << " " << Cmds->Match << " - " << Cmds->Help << std::endl; + } +} + /*}}}*/ static void BinarySpecificConfiguration(char const * const Binary) /*{{{*/ { std::string const binary = flNotDir(Binary); @@ -397,6 +416,11 @@ std::vector ParseCommandLine(CommandLine &CmdL, APT_CMD c std::vector const CmdsWithHelp = GetCommands(); std::vector Cmds; + if (CmdsWithHelp.empty() == false) + { + CommandLine::Dispatch const help = { "help", [](CommandLine &){return false;} }; + Cmds.push_back(std::move(help)); + } for (auto const& cmd : CmdsWithHelp) Cmds.push_back({cmd.Match, cmd.Handler}); @@ -414,7 +438,7 @@ std::vector ParseCommandLine(CommandLine &CmdL, APT_CMD c (Sys != NULL && pkgInitSystem(*_config, *Sys) == false)) { if (_config->FindB("version") == true) - ShowHelp(CmdL, CmdsWithHelp.data()); + ShowCommonHelp(Binary, CmdL, CmdsWithHelp.data()); _error->DumpErrors(); exit(100); @@ -424,12 +448,12 @@ std::vector ParseCommandLine(CommandLine &CmdL, APT_CMD c if (_config->FindB("help") == true || _config->FindB("version") == true || (CmdL.FileSize() > 0 && strcmp(CmdL.FileList[0], "help") == 0)) { - ShowHelp(CmdL, CmdsWithHelp.data()); + ShowCommonHelp(Binary, CmdL, CmdsWithHelp.data()); exit(0); } if (Cmds.empty() == false && CmdL.FileSize() == 0) { - ShowHelp(CmdL, CmdsWithHelp.data()); + ShowCommonHelp(Binary, CmdL, CmdsWithHelp.data()); exit(1); } return Cmds; -- cgit v1.2.3