From d9319cee6ff10b42e64145c82dfb246a1b3e551c Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Wed, 21 Apr 2010 15:16:13 +0200 Subject: * dselect/install: - modernize if-statements not to use 'x' (Closes: #577117) Thanks to Jari Aalto for spotting & patching! --- dselect/install | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'dselect') diff --git a/dselect/install b/dselect/install index 6779698e0..109307f4d 100755 --- a/dselect/install +++ b/dselect/install @@ -46,7 +46,7 @@ yesno() { echo $ans | tr YN yn } -if [ x$WAIT = "xtrue" ]; then +if [ "$WAIT" = "true" ]; then $APTGET $OPTS "$APT_OPT0" "$APT_OPT1" -d dselect-upgrade echo $"Press enter to continue." && read RES $APTGET $OPTS "$APT_OPT0" "$APT_OPT1" dselect-upgrade @@ -70,8 +70,8 @@ if [ $RES -eq 0 ]; then fi NEWLS=`ls -ld $ARCHIVES` - if [ x$CHECKDIR = "xtrue" ]; then - if [ "x$OLDLS" = "x$NEWLS" ]; then + if [ "$CHECKDIR" = "true" ]; then + if [ "$OLDLS" = "$NEWLS" ]; then exit 0 fi fi -- cgit v1.2.3 From cb658c4eea4bf18295c4acacd637cd94e2473bbc Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Wed, 21 Apr 2010 15:25:12 +0200 Subject: replace backticks with POSIX $() (Closes: #577116) And again thanks to Jari Aalto for spotting & patching! --- dselect/install | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'dselect') diff --git a/dselect/install b/dselect/install index 109307f4d..3ef213550 100755 --- a/dselect/install +++ b/dselect/install @@ -12,11 +12,11 @@ DPKG_OPTS="--admindir=$1" APT_OPT0="-oDir::State::status=$1/status" APT_OPT1="-oDPkg::Options::=$DPKG_OPTS" set -e -RES=`apt-config shell CLEAN DSelect::Clean OPTS DSelect::Options \ +RES=$(apt-config shell CLEAN DSelect::Clean OPTS DSelect::Options \ DPKG Dir::Bin::dpkg/f APTGET Dir::Bin::apt-get/f \ ARCHIVES Dir::Cache::Archives/d \ WAIT DSelect::WaitAfterDownload/b \ - CHECKDIR DSelect::CheckDir/b` + CHECKDIR DSelect::CheckDir/b) eval $RES set +e @@ -64,12 +64,12 @@ fi # Finished OK if [ $RES -eq 0 ]; then - if [ `ls $ARCHIVES $ARCHIVES/partial | egrep -v "^lock$|^partial$" | wc -l` \ + if [ $(ls $ARCHIVES $ARCHIVES/partial | egrep -v "^lock$|^partial$" | wc -l) \ -eq 0 ]; then exit 0 fi - NEWLS=`ls -ld $ARCHIVES` + NEWLS=$(ls -ld $ARCHIVES) if [ "$CHECKDIR" = "true" ]; then if [ "$OLDLS" = "$NEWLS" ]; then exit 0 @@ -77,7 +77,7 @@ if [ $RES -eq 0 ]; then fi # Check the cleaning mode - case `echo $CLEAN | tr '[:upper:]' '[:lower:]'` in + case $(echo $CLEAN | tr '[:upper:]' '[:lower:]') in auto) $APTGET "$APT_OPT0" "$APT_OPT1" autoclean && echo $"Press enter to continue." && read RES && exit 0; @@ -89,7 +89,7 @@ if [ $RES -eq 0 ]; then prompt) exec 3>&1 echo -n $"Do you want to erase any previously downloaded .deb files?" - if [ `yesno "" y` = y ]; then + if [ $(yesno "" y) = y ]; then $APTGET "$APT_OPT0" "$APT_OPT1" clean && echo $"Press enter to continue." && read RES && exit 0; fi -- cgit v1.2.3