From 1adcf56bec7d2127d83aa423916639740fe8e586 Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Wed, 13 Dec 2017 21:39:16 +0100 Subject: avoid some useless casts reported by -Wuseless-cast The casts are useless, but the reports show some where we can actually improve the code by replacing them with better alternatives like converting whatever int type into a string instead of casting to a specific one which might in the future be too small. Reported-By: gcc -Wuseless-cast --- ftparchive/writer.cc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'ftparchive') diff --git a/ftparchive/writer.cc b/ftparchive/writer.cc index bb855d532..91cb72d01 100644 --- a/ftparchive/writer.cc +++ b/ftparchive/writer.cc @@ -477,10 +477,7 @@ bool PackagesWriter::DoPackage(string FileName) // This lists all the changes to the fields we are going to make. std::vector Changes; - - std::string Size; - strprintf(Size, "%llu", (unsigned long long) FileSize); - Changes.push_back(pkgTagSection::Tag::Rewrite("Size", Size)); + Changes.push_back(pkgTagSection::Tag::Rewrite("Size", std::to_string(FileSize))); for (HashStringList::const_iterator hs = Db.HashesList.begin(); hs != Db.HashesList.end(); ++hs) { -- cgit v1.2.3