From 4460551841d909d3ee9c1de00156ed3cdf8b1665 Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Tue, 5 Jul 2016 13:07:29 +0200 Subject: avoid 416 response teardown binding to null pointer methods/http.cc:640:13: runtime error: reference binding to null pointer of type 'struct FileFd' This reference is never used in the cases it has a nullptr, so the practical difference is non-existent, but its a bug still. Reported-By: gcc -fsanitize=undefined --- methods/https.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'methods/https.h') diff --git a/methods/https.h b/methods/https.h index 74b86a24f..2fa714c7b 100644 --- a/methods/https.h +++ b/methods/https.h @@ -45,7 +45,7 @@ class HttpsServerState : public ServerState virtual bool Close() APT_OVERRIDE { return false; } virtual bool InitHashes(HashStringList const &ExpectedHashes) APT_OVERRIDE; virtual Hashes * GetHashes() APT_OVERRIDE; - virtual bool Die(FileFd &/*File*/) APT_OVERRIDE { return false; } + virtual bool Die(FileFd * const /*File*/) APT_OVERRIDE { return false; } virtual bool Flush(FileFd * const /*File*/) APT_OVERRIDE { return false; } virtual bool Go(bool /*ToFile*/, FileFd * const /*File*/) APT_OVERRIDE { return false; } -- cgit v1.2.3