From 9dd940ed722e8235c615e79b7eb688eb427e9a23 Mon Sep 17 00:00:00 2001
From: David Kalnischkies <david@kalnischkies.de>
Date: Wed, 5 Nov 2014 18:33:07 +0100
Subject: Assert statement calls a function which may have desired side
 effects: 'pos_is_okay'

It does not have any desired sideeffect, so we just mark it as const to
properly advertise this fact to developer, compiler and linter alike.

Reported-By: cppcheck
Git-Dch: Ignore
---
 methods/rred.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'methods')

diff --git a/methods/rred.cc b/methods/rred.cc
index cabb3c456..774b58a40 100644
--- a/methods/rred.cc
+++ b/methods/rred.cc
@@ -150,11 +150,11 @@ class FileChanges {
    std::list<struct Change>::iterator where;
    size_t pos; // line number is as far left of iterator as possible
 
-   bool pos_is_okay(void)
+   bool pos_is_okay(void) const
    {
 #ifdef POSDEBUG
       size_t cpos = 0;
-      std::list<struct Change>::iterator x;
+      std::list<struct Change>::const_iterator x;
       for (x = changes.begin(); x != where; ++x) {
 	 assert(x != changes.end());
 	 cpos += x->offset + x->add_cnt;
-- 
cgit v1.2.3