From b4450f1dd6bca537e60406b2383ab154a3e1485f Mon Sep 17 00:00:00 2001 From: David Kalnischkies Date: Wed, 8 Jun 2016 17:31:45 +0200 Subject: don't explicitly configure the last round of packages We end our operation by calling "dpkg --configure -a", so instead of running a (big) configure run with all packages mentioned explicitly before this, we simply skip them and let them be handled by this call implicitly. There isn't really an observeable gain to be had here from a speed point, but it helps in avoiding an (uncommon) problem of having a too long commandline passed to dpkg, which we would split up (probably incorrectly). --- test/integration/test-apt-progress-fd | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'test/integration/test-apt-progress-fd') diff --git a/test/integration/test-apt-progress-fd b/test/integration/test-apt-progress-fd index 86eaa1354..57728ca81 100755 --- a/test/integration/test-apt-progress-fd +++ b/test/integration/test-apt-progress-fd @@ -25,8 +25,7 @@ pmstatus:testing:50.0000:Preparing to configure testing (amd64) pmstatus:dpkg-exec:50.0000:Running dpkg pmstatus:testing:50.0000:Configuring testing (amd64) pmstatus:testing:66.6667:Configuring testing (amd64) -pmstatus:testing:83.3333:Installed testing (amd64) -pmstatus:dpkg-exec:83.3333:Running dpkg' +pmstatus:testing:83.3333:Installed testing (amd64)' # upgrade exec 3> apt-progress.log @@ -41,8 +40,7 @@ pmstatus:testing:50.0000:Preparing to configure testing (amd64) pmstatus:dpkg-exec:50.0000:Running dpkg pmstatus:testing:50.0000:Configuring testing (amd64) pmstatus:testing:66.6667:Configuring testing (amd64) -pmstatus:testing:83.3333:Installed testing (amd64) -pmstatus:dpkg-exec:83.3333:Running dpkg' +pmstatus:testing:83.3333:Installed testing (amd64)' # reinstall exec 3> apt-progress.log @@ -57,8 +55,7 @@ pmstatus:testing:50.0000:Preparing to configure testing (amd64) pmstatus:dpkg-exec:50.0000:Running dpkg pmstatus:testing:50.0000:Configuring testing (amd64) pmstatus:testing:66.6667:Configuring testing (amd64) -pmstatus:testing:83.3333:Installed testing (amd64) -pmstatus:dpkg-exec:83.3333:Running dpkg' +pmstatus:testing:83.3333:Installed testing (amd64)' # and remove exec 3> apt-progress.log @@ -83,7 +80,6 @@ pmstatus:testing2:50.0000:Preparing to configure testing2 (i386) pmstatus:dpkg-exec:50.0000:Running dpkg pmstatus:testing2:50.0000:Configuring testing2 (i386) pmstatus:testing2:66.6667:Configuring testing2 (i386) -pmstatus:testing2:83.3333:Installed testing2 (i386) -pmstatus:dpkg-exec:83.3333:Running dpkg' +pmstatus:testing2:83.3333:Installed testing2 (i386)' rm -f apt-progress*.log -- cgit v1.2.3