summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPino Toscano <pino@debian.org>2012-01-20 01:34:31 +0100
committerDavid Kalnischkies <kalnischkies@gmail.com>2012-01-20 01:34:31 +0100
commit18aea9e6c38ec0397e546563b8a54a99b431028b (patch)
tree173caa106aa508973ba1f3ddbc6e537b382fb8fc
parentaaab10075397cb4f2ec262c5d478f7ea8acd2d23 (diff)
* test/libapt/globalerror_test.cc:
- errno 0 has a different strerror on hurd, so generate the expected message dynamically instead of hardcoding 'Success' (Closes: #656530)
-rw-r--r--debian/changelog7
-rw-r--r--test/libapt/globalerror_test.cc7
2 files changed, 11 insertions, 3 deletions
diff --git a/debian/changelog b/debian/changelog
index 299afcf54..99c3a2032 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -22,7 +22,12 @@ apt (0.8.16~exp12) experimental; urgency=low
which generates malformed requests, thanks Mel Collins for the hint!
(Closes: #646381)
- -- David Kalnischkies <kalnischkies@gmail.com> Thu, 19 Jan 2012 23:43:03 +0100
+ [ Pino Toscano ]
+ * test/libapt/globalerror_test.cc:
+ - errno 0 has a different strerror on hurd, so generate the expected
+ message dynamically instead of hardcoding 'Success' (Closes: #656530)
+
+ -- David Kalnischkies <kalnischkies@gmail.com> Fri, 20 Jan 2012 01:31:30 +0100
apt (0.8.16~exp11) experimental; urgency=low
diff --git a/test/libapt/globalerror_test.cc b/test/libapt/globalerror_test.cc
index 5d27414f9..72044d493 100644
--- a/test/libapt/globalerror_test.cc
+++ b/test/libapt/globalerror_test.cc
@@ -3,9 +3,12 @@
#include "assert.h"
#include <string>
#include <errno.h>
+#include <string.h>
int main(int argc,char *argv[])
{
+ std::string const textOfErrnoZero(strerror(0));
+
equals(_error->empty(), true);
equals(_error->PendingError(), false);
equals(_error->Notice("%s Notice", "A"), false);
@@ -80,7 +83,7 @@ int main(int argc,char *argv[])
equals(_error->PendingError(), true);
equals(_error->PopMessage(text), true);
equals(_error->PendingError(), false);
- equals(text, "Something horrible happend 2 times - errno (0: Success)");
+ equals(text, std::string("Something horrible happend 2 times - errno (0: ").append(textOfErrnoZero).append(")"));
equals(_error->empty(), true);
std::string longText;
@@ -92,7 +95,7 @@ int main(int argc,char *argv[])
equals(_error->Errno("errno", "%s horrible %s %d times", longText.c_str(), "happend", 2), false);
equals(_error->PopMessage(text), true);
- equals(text, std::string(longText).append(" horrible happend 2 times - errno (0: Success)"));
+ equals(text, std::string(longText).append(" horrible happend 2 times - errno (0: ").append(textOfErrnoZero).append(")"));
equals(_error->Warning("Репозиторий не обновлён и будут %d %s", 4, "test"), false);
equals(_error->PopMessage(text), false);