summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Kalnischkies <kalnischkies@gmail.com>2011-05-17 18:23:20 +0200
committerDavid Kalnischkies <kalnischkies@gmail.com>2011-05-17 18:23:20 +0200
commita16dec4dbe7847597025f44f84027bb3f25f4f42 (patch)
tree5884e1af60060ba183c0a468380c863e221b2f89
parent3d619a202a6fbcaaaf6a6540b06c5deb3a50a3be (diff)
if a Breaks can't be upgraded, remove it. If it or a Conflict
can't be removed the installation of the breaker fails.
-rw-r--r--apt-pkg/depcache.cc11
-rw-r--r--debian/changelog4
2 files changed, 9 insertions, 6 deletions
diff --git a/apt-pkg/depcache.cc b/apt-pkg/depcache.cc
index f84ec25ca..1d905df2e 100644
--- a/apt-pkg/depcache.cc
+++ b/apt-pkg/depcache.cc
@@ -1172,16 +1172,17 @@ bool pkgDepCache::MarkInstall(PkgIterator const &Pkg,bool AutoInst,
continue;
if (PkgState[Pkg->ID].CandidateVer != *I &&
- Start->Type == Dep::DpkgBreaks)
- MarkInstall(Pkg,true,Depth + 1, false, ForceImportantDeps);
- else
- MarkDelete(Pkg,false,Depth + 1, false);
+ Start->Type == Dep::DpkgBreaks &&
+ MarkInstall(Pkg,true,Depth + 1, false, ForceImportantDeps) == true)
+ continue;
+ else if (MarkDelete(Pkg,false,Depth + 1, false) == false)
+ break;
}
continue;
}
}
- return true;
+ return Dep.end() == true;
}
/*}}}*/
// DepCache::IsInstallOk - check if it is ok to install this package /*{{{*/
diff --git a/debian/changelog b/debian/changelog
index 837571173..9fc6dc193 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,12 +14,14 @@ apt (0.8.15) UNRELEASED; urgency=low
- use a boolean instead of an int for Add/Remove in AddStates
similar to how it works with AddSizes
- let the Mark methods return if their marking was successful
+ - if a Breaks can't be upgraded, remove it. If it or a Conflict
+ can't be removed the installation of the breaker fails.
[ Stefano Zacchiroli ]
* doc/external-dependency-solver-protocol.txt:
- describe EDSP and the configuration interface around it
- -- David Kalnischkies <kalnischkies@gmail.com> Tue, 17 May 2011 17:53:44 +0200
+ -- David Kalnischkies <kalnischkies@gmail.com> Tue, 17 May 2011 17:59:24 +0200
apt (0.8.14.2) UNRELEASED; urgency=low