summaryrefslogtreecommitdiff
path: root/CMake/vendor_substitute.cmake
diff options
context:
space:
mode:
authorJulian Andres Klode <jak@debian.org>2016-12-29 14:16:07 +0100
committerJulian Andres Klode <jak@debian.org>2017-01-17 01:59:15 +0100
commit994515e689dcc5f963f5fed58284831750a5da03 (patch)
treeb3e010a1d151fd0c0241bc3c193c817a9061f0af /CMake/vendor_substitute.cmake
parent1dcd7d291be1d39127c4b95778549f323e61ef15 (diff)
https: Quote path in URL before passing it to curl
Curl requires URLs to be urlencoded. We are however giving it undecoded URLs. This causes it go completely nuts if there is a space in the URI, producing requests like: GET /a file HTTP/1.1 which the servers then interpret as a GET request for "/a" with HTTP version "file" or some other non-sense. This works around the issue by encoding the path component of the URL. I'm not sure if we should encode other parts of the URL as well, this one seems to do the trick for the actual issue at hand. A more correct fix is to avoid the dequoting and (re-)quoting of URLs when a redirect occurs / a new request is sent. That's been on the radar for probably a year or two now, but nobody bothered implementing that yet. LP: #1651923
Diffstat (limited to 'CMake/vendor_substitute.cmake')
0 files changed, 0 insertions, 0 deletions