diff options
| author | David Kalnischkies <david@kalnischkies.de> | 2015-11-04 21:08:55 +0100 |
|---|---|---|
| committer | David Kalnischkies <david@kalnischkies.de> | 2015-11-05 12:21:33 +0100 |
| commit | 258b9e512c4001e806c5c0966acecd3d742ec6e9 (patch) | |
| tree | c8bdbb43dd9e1b5d54b90e4845065a653d585ca5 /apt-pkg/acquire-item.cc | |
| parent | 9fb4e6510faaa9c84b88d4cb567bf3deebf8e0b7 (diff) | |
apply various suggestions made by cppcheck
Reported-By: cppcheck
Git-Dch: Ignore
Diffstat (limited to 'apt-pkg/acquire-item.cc')
| -rw-r--r-- | apt-pkg/acquire-item.cc | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/apt-pkg/acquire-item.cc b/apt-pkg/acquire-item.cc index 834776404..9d1c2cc61 100644 --- a/apt-pkg/acquire-item.cc +++ b/apt-pkg/acquire-item.cc @@ -2237,14 +2237,10 @@ bool pkgAcqIndexDiffs::QueueNextDiff() /*{{{*/ // remove all patches until the next matching patch is found // this requires the Index file to be ordered - for(vector<DiffInfo>::iterator I = available_patches.begin(); - available_patches.empty() == false && - I != available_patches.end() && - I->result_hashes != LocalHashes; - ++I) - { - available_patches.erase(I); - } + available_patches.erase(available_patches.begin(), + std::find_if(available_patches.begin(), available_patches.end(), [&](DiffInfo const &I) { + return I.result_hashes == LocalHashes; + })); // error checking and falling back if no patch was found if(available_patches.empty() == true) |