diff options
| author | Julian Andres Klode <julian.klode@canonical.com> | 2018-09-24 11:38:55 +0200 |
|---|---|---|
| committer | Julian Andres Klode <julian.klode@canonical.com> | 2018-09-24 12:13:03 +0200 |
| commit | e02297b8e22dae04872fe6fab6dba966de65dbba (patch) | |
| tree | 17119f9620469981c366bb7aa84c8509c9af66ca /apt-pkg/cachefile.h | |
| parent | 089e627153781ae7c320a5a0724c6c70d684b689 (diff) | |
pkgCacheFile: Only unlock in destructor if locked before
pkgCacheFile's destructor unlocks the system, which is confusing
if you did not open the cachefile with WithLock set. Create a private
data instance that holds the value of WithLock.
This regression was introduced in commit b2e465d6d32d2dc884f58b94acb7e35f671a87fe:
Join with aliencode
Author: jgg
Date: 2001-02-20 07:03:16 GMT
Join with aliencode
by replacing a "Lock" member that was only initialized when the lock
was taken by calls to Lock, UnLock; with the latter also taking place
if the former did not occur.
Regression-Of: b2e465d6d32d2dc884f58b94acb7e35f671a87fe
LP: #1794053
Diffstat (limited to 'apt-pkg/cachefile.h')
| -rw-r--r-- | apt-pkg/cachefile.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/apt-pkg/cachefile.h b/apt-pkg/cachefile.h index 097876b3a..ed5d5c57c 100644 --- a/apt-pkg/cachefile.h +++ b/apt-pkg/cachefile.h @@ -36,8 +36,9 @@ class OpProgress; class pkgCacheFile { + struct Private; /** \brief dpointer placeholder (for later in case we need it) */ - void * const d; + Private *const d; bool ExternOwner; protected: |