diff options
| author | David Kalnischkies <david@kalnischkies.de> | 2016-08-31 10:11:07 +0200 |
|---|---|---|
| committer | David Kalnischkies <david@kalnischkies.de> | 2016-09-01 16:13:14 +0200 |
| commit | 644478e8db56f305601c3628a74e53de048b28c8 (patch) | |
| tree | edcd2bfc85f7fdcdef458b8c3b5ad729d4d6481a /apt-pkg/contrib/md5.cc | |
| parent | 0343b48e06fb990ee15a020bc6716b1a5a984e14 (diff) | |
try not to call memcpy with length 0 in hash calculations
memcpy is marked as nonnull for its input, but ignores the input anyhow
if the declared length is zero. Our SHA2 implementations do this as
well, it was "just" MD5 and SHA1 missing, so we add the length check
here as well as along the callstack as it is really pointless to do all
these method calls for "nothing".
Reported-By: gcc -fsanitize=undefined
Diffstat (limited to 'apt-pkg/contrib/md5.cc')
| -rw-r--r-- | apt-pkg/contrib/md5.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/apt-pkg/contrib/md5.cc b/apt-pkg/contrib/md5.cc index b487a96f9..ff7868fe2 100644 --- a/apt-pkg/contrib/md5.cc +++ b/apt-pkg/contrib/md5.cc @@ -187,6 +187,8 @@ bool MD5Summation::Add(const unsigned char *data,unsigned long long len) { if (Done == true) return false; + if (len == 0) + return true; uint32_t *buf = (uint32_t *)Buf; uint32_t *bytes = (uint32_t *)Bytes; |