summaryrefslogtreecommitdiff
path: root/apt-pkg/contrib/string_view.h
diff options
context:
space:
mode:
authorDavid Kalnischkies <david@kalnischkies.de>2016-08-12 19:11:01 +0200
committerDavid Kalnischkies <david@kalnischkies.de>2016-08-12 20:49:54 +0200
commit9445fa62386c80c9822e77484d30b2109aa0f2dc (patch)
tree3e82c505e57ced6f017f5b63ca04f49fc5e70802 /apt-pkg/contrib/string_view.h
parent15fe8e62d37bc87114c59d385bed7ceefb72886b (diff)
drop incorrect const attribute from DirectoryExists
Since its existence in 2010 DirectoryExists was always marked with this attribute, but for no real reason. Arguably a check for the existence of the file is not modifying global state, so theoretically this shouldn't be a problem. It is wrong from a logical point of view through as between two calls the directory could be created so the promise we made to the compiler that it could remove the second call would be wrong, so API wise it is wrong. It's a bit mysterious that this is only observeable on ppc64el and can be fixed by reordering code ever so slightly, but in the end its more our fault for adding this attribute than the compilers fault for doing something silly based on the attribute. LP: 1473674
Diffstat (limited to 'apt-pkg/contrib/string_view.h')
0 files changed, 0 insertions, 0 deletions