diff options
| author | David Kalnischkies <david@kalnischkies.de> | 2016-06-08 13:44:29 +0200 |
|---|---|---|
| committer | David Kalnischkies <david@kalnischkies.de> | 2016-06-08 17:27:19 +0200 |
| commit | 007d8b488787f4c33ced5937f22f99f1b759088a (patch) | |
| tree | ee6d42146b4bc01b84c947e7755888a4dd1a1b45 /apt-pkg/edsp.cc | |
| parent | 3a487cc03dec3488d0fa3008d04747bb1b4b0baf (diff) | |
edsp: drop privileges before executing solvers
Most (if not all) solvers should be able to run perfectly fine without
root privileges as they get the entire state they are supposed to work
on via stdin and do not perform any action directly, but just pass
suggestions on via stdout.
The new default is to run them all as _apt hence, but each solver can
configure another user if it chooses/must. The security benefits are
minimal at best, but it helps preventing silly mistakes (see
35f3ed061f10a25a3fb28bc988fddbb976344c4d) and that is always good.
Note that our 'apt' and 'dump' solver already dropped privileges if they
had them.
Diffstat (limited to 'apt-pkg/edsp.cc')
| -rw-r--r-- | apt-pkg/edsp.cc | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/apt-pkg/edsp.cc b/apt-pkg/edsp.cc index fcff208c1..890252ba4 100644 --- a/apt-pkg/edsp.cc +++ b/apt-pkg/edsp.cc @@ -968,14 +968,19 @@ static pid_t ExecuteExternal(char const* const type, char const * const binary, dup2(external[3], STDOUT_FILENO); auto const dumpfile = _config->FindFile((std::string("Dir::Log::") + type).c_str()); auto const dumpdir = flNotFile(dumpfile); + auto const runasuser = _config->Find(std::string("APT::") + type + "::" + binary + "::RunAsUser", + _config->Find(std::string("APT::") + type + "::RunAsUser", + _config->Find("APT::Sandbox::User"))); if (dumper.empty() || dumpfile.empty() || dumper == file || CreateAPTDirectoryIfNeeded(dumpdir, dumpdir) == false) { + _config->Set("APT::Sandbox::User", runasuser); + DropPrivileges(); char const * const calling[] = { file.c_str(), nullptr }; execv(calling[0], const_cast<char**>(calling)); } else { - char const * const calling[] = { dumper.c_str(), dumpfile.c_str(), file.c_str(), nullptr }; + char const * const calling[] = { dumper.c_str(), "--user", runasuser.c_str(), dumpfile.c_str(), file.c_str(), nullptr }; execv(calling[0], const_cast<char**>(calling)); } std::cerr << "Failed to execute " << type << " '" << binary << "'!" << std::endl; |