diff options
| author | Julian Andres Klode <jak@debian.org> | 2015-08-11 11:05:57 +0200 |
|---|---|---|
| committer | Julian Andres Klode <jak@debian.org> | 2015-08-11 13:59:15 +0200 |
| commit | c9d715346cae0bd53264d7c25d5af79ca6365707 (patch) | |
| tree | 78b6e5d8f5fdc2c6cca1c8d436cc148e4d7d8da6 /apt-pkg/sourcelist.cc | |
| parent | 1d203ce78e6f80792e8c1f99701ff1b1daca534c (diff) | |
Fix an obscure warning from GCC
It complained about the previous code:
apt-pkg/sourcelist.cc: In destructor ‘pkgSourceList::~pkgSourceList()’:
apt-pkg/sourcelist.cc:278:4: warning: cannot optimize loop, the loop counter may overflow [-Wunsafe-loop-optimizations]
for (pkgIndexFile * const File : VolatileFiles)
^
There really cannot be an overflow, though. Rewriting it like this
seems to fix it.
Diffstat (limited to 'apt-pkg/sourcelist.cc')
| -rw-r--r-- | apt-pkg/sourcelist.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/apt-pkg/sourcelist.cc b/apt-pkg/sourcelist.cc index 46e51f592..3e714667c 100644 --- a/apt-pkg/sourcelist.cc +++ b/apt-pkg/sourcelist.cc @@ -275,8 +275,8 @@ pkgSourceList::~pkgSourceList() for (const_iterator I = SrcList.begin(); I != SrcList.end(); ++I) delete *I; SrcList.clear(); - for (pkgIndexFile * const File : VolatileFiles) - delete File; + for (auto F = VolatileFiles.begin(); F != VolatileFiles.end(); ++F) + delete (*F); VolatileFiles.clear(); } /*}}}*/ |