diff options
author | Julian Andres Klode <jak@debian.org> | 2016-01-23 13:15:31 +0100 |
---|---|---|
committer | Julian Andres Klode <jak@debian.org> | 2016-01-23 15:20:52 +0100 |
commit | 7dd0c2eb45874d3df9a9ee2034501659548a1b97 (patch) | |
tree | 1c431a2f46c51492d216fa1f8e3e9b17c1466d6a /apt-pkg/version.cc | |
parent | 19819ac58a420275e0ae9aa7e2a34c72cba8af5e (diff) |
Remap StringView instances pointing into the cache
It turns out that StringViews might need to be remapped in some
places because they come from the cache. For example, some sites
pass a Ver.VerStr() to NewProvides().
Such a StringView would become invalid during the duration of
the call if the cache is remapped, causing the program to die
with a segmentation fault.
We can take care of those issues by remapping string views in
the same way we remap all the iterators. String views are only
remapped if they point into the cache though, this allows us
to write more generic code on the callee site without having
to check whether the view points into the cache or not.
That's not as efficient as possible, but the overhead does not
appear to be measurable.
Closes: #812251
Diffstat (limited to 'apt-pkg/version.cc')
0 files changed, 0 insertions, 0 deletions