diff options
| author | David Kalnischkies <david@kalnischkies.de> | 2016-06-09 21:06:48 +0200 |
|---|---|---|
| committer | David Kalnischkies <david@kalnischkies.de> | 2016-06-10 10:49:34 +0200 |
| commit | 6f35be91c9e86e463bca7df6eadf05412c7b732c (patch) | |
| tree | 118d35c699e816941f6fc6faf09d24b71cca06d2 /apt-pkg | |
| parent | bdc42211700ef0f6f40e4ef3f362e52d684d70fb (diff) | |
don't leak an FD in lz4 (de)compression
Seen first in #826783, but as this buglog also shows leaked uncompressed
files as well we don't close it just yet.
Diffstat (limited to 'apt-pkg')
| -rw-r--r-- | apt-pkg/contrib/fileutl.cc | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/apt-pkg/contrib/fileutl.cc b/apt-pkg/contrib/fileutl.cc index 6bfa5ca92..94d1432cf 100644 --- a/apt-pkg/contrib/fileutl.cc +++ b/apt-pkg/contrib/fileutl.cc @@ -1535,7 +1535,7 @@ public: return false; unsigned int flags = (Mode & (FileFd::WriteOnly|FileFd::ReadOnly)); - if (backend.OpenDescriptor(iFd, flags) == false) + if (backend.OpenDescriptor(iFd, flags, FileFd::None, true) == false) return false; // Write the file header @@ -1646,6 +1646,11 @@ public: res = LZ4F_freeDecompressionContext(dctx); dctx = nullptr; } + if (backend.IsOpen()) + { + backend.Close(); + filefd->iFd = -1; + } return LZ4F_isError(res) == false; } |