diff options
author | David Kalnischkies <david@kalnischkies.de> | 2017-10-05 15:27:58 +0200 |
---|---|---|
committer | David Kalnischkies <david@kalnischkies.de> | 2017-10-05 17:30:25 +0200 |
commit | bf6c329cd9f484f9e6b711f157a3b60fb3a8563d (patch) | |
tree | b78abca2fa5ef0f9fc8fd5bfe315d1d3cd48375c /apt-private/private-upgrade.cc | |
parent | 50920fca5eff021f810d5de0cc9d2fa4d6068c50 (diff) |
avoid using NULL in varadic function for cmdline parsing
cppcheck reports:
(portability) Passing NULL after the last typed argument to a variadic
function leads to undefined behaviour.
We don't ship on any platform which has this as undefined behaviour
through – or it would be pretty well defined "bad" behaviour which
always works, so even through UB is a trigger word, its hardly
noteworthy as a change (and as a bonus the scanners of gcc/clang
don't consider it UB).
The commonly accepted method of fixing that seems to be (const
char*)NULL, but it is in fact much simpler to just switch to the varadic
functions C++ provides resolving the warning and reducing code.
Reported-By: cppcheck
Gbp-Dch: Ignore
Diffstat (limited to 'apt-private/private-upgrade.cc')
0 files changed, 0 insertions, 0 deletions