summaryrefslogtreecommitdiff
path: root/methods/connect.cc
diff options
context:
space:
mode:
authorJulian Andres Klode <jak@debian.org>2018-01-02 21:53:46 +0100
committerJulian Andres Klode <jak@debian.org>2018-01-03 15:26:47 +0100
commit2369d1249ce7119abb30b616182454a56f124f8d (patch)
tree446d4d849d43fd8fc97b924bd5c056505616be9b /methods/connect.cc
parent23ddea7485ea5d28b8ad1a0d35e0d8c4de7ad54b (diff)
connect: Extract a Connection struct
This struct holds information about a connection attempt, like the addrinfo, the resolved address, the fd for the connection, and so on. Gbp-Dch: ignore
Diffstat (limited to 'methods/connect.cc')
-rw-r--r--methods/connect.cc44
1 files changed, 36 insertions, 8 deletions
diff --git a/methods/connect.cc b/methods/connect.cc
index 22dd41bee..c1a9d347f 100644
--- a/methods/connect.cc
+++ b/methods/connect.cc
@@ -112,16 +112,43 @@ std::unique_ptr<MethodFd> MethodFd::FromFd(int iFd)
// DoConnect - Attempt a connect operation /*{{{*/
// ---------------------------------------------------------------------
/* This helper function attempts a connection to a single address. */
-static ResultState DoConnect(struct addrinfo *Addr, std::string const &Host,
- unsigned long TimeOut, std::unique_ptr<MethodFd> &Fd, aptMethod *Owner)
+struct Connection
{
- // Show a status indicator
+ struct addrinfo *Addr;
+ std::string Host;
+ aptMethod *Owner;
+ std::unique_ptr<FdFd> Fd;
char Name[NI_MAXHOST];
char Service[NI_MAXSERV];
- Fd.reset(new FdFd());
- Name[0] = 0;
- Service[0] = 0;
+ Connection(struct addrinfo *Addr, std::string const &Host, aptMethod *Owner) : Addr(Addr), Host(Host), Owner(Owner), Fd(new FdFd()), Name{0}, Service{0}
+ {
+ }
+
+ // Allow moving values, but not connections.
+ Connection(Connection &&Conn) = default;
+ Connection(const Connection &Conn) = delete;
+ Connection &operator=(const Connection &) = delete;
+ Connection &operator=(Connection &&Conn) = default;
+
+ ~Connection()
+ {
+ if (Fd != nullptr)
+ {
+ Fd->Close();
+ }
+ }
+
+ std::unique_ptr<MethodFd> Take()
+ {
+ return std::move(Fd);
+ }
+
+ ResultState DoConnect(unsigned long TimeOut);
+};
+
+ResultState Connection::DoConnect(unsigned long TimeOut)
+{
getnameinfo(Addr->ai_addr,Addr->ai_addrlen,
Name,sizeof(Name),Service,sizeof(Service),
NI_NUMERICHOST|NI_NUMERICSERV);
@@ -350,13 +377,14 @@ static ResultState ConnectToHostname(std::string const &Host, int const Port,
for (auto CurHost : Addresses)
{
_error->Discard();
- auto const result = DoConnect(CurHost, Host, TimeOut, Fd, Owner);
+ Connection Conn(CurHost, Host, Owner);
+ auto const result = Conn.DoConnect(TimeOut);
if (result == ResultState::SUCCESSFUL)
{
+ Fd = Conn.Take();
LastUsed = CurHost;
return result;
}
- Fd->Close();
}
if (_error->PendingError() == true)