diff options
| author | David Kalnischkies <david@kalnischkies.de> | 2016-07-05 13:07:29 +0200 |
|---|---|---|
| committer | Julian Andres Klode <jak@debian.org> | 2016-08-31 13:49:37 +0200 |
| commit | 6862a9b0320d8c07db3a86b20131ab78c5bc4708 (patch) | |
| tree | c57076cfd974a1372f12d6f9a7a8765f2b5978a3 /methods/https.h | |
| parent | d7c10ebe247cddafe54a4656ceb05a28010562b1 (diff) | |
avoid 416 response teardown binding to null pointer
methods/http.cc:640:13: runtime error: reference binding to null pointer
of type 'struct FileFd'
This reference is never used in the cases it has a nullptr, so the
practical difference is non-existent, but its a bug still.
Reported-By: gcc -fsanitize=undefined
(cherry picked from commit 4460551841d909d3ee9c1de00156ed3cdf8b1665)
Diffstat (limited to 'methods/https.h')
| -rw-r--r-- | methods/https.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/methods/https.h b/methods/https.h index 4d50c5a04..7d49d9882 100644 --- a/methods/https.h +++ b/methods/https.h @@ -47,7 +47,7 @@ class HttpsServerState : public ServerState virtual bool Close() APT_OVERRIDE { return false; } virtual bool InitHashes(HashStringList const &ExpectedHashes) APT_OVERRIDE; virtual Hashes * GetHashes() APT_OVERRIDE; - virtual bool Die(FileFd &/*File*/) APT_OVERRIDE { return false; } + virtual bool Die(FileFd * const /*File*/) APT_OVERRIDE { return false; } virtual bool Flush(FileFd * const /*File*/) APT_OVERRIDE { return false; } virtual bool Go(bool /*ToFile*/, FileFd * const /*File*/) APT_OVERRIDE { return false; } |