diff options
| author | David Kalnischkies <david@kalnischkies.de> | 2016-08-24 09:47:48 +0200 |
|---|---|---|
| committer | David Kalnischkies <david@kalnischkies.de> | 2016-08-24 10:24:41 +0200 |
| commit | 2e2865ae53a65c00dd55a892d5b48458f3110366 (patch) | |
| tree | 75547baee53574ba399f179b7a62ab651e8cf7c0 /test/integration/test-bug-605394-versioned-or-groups | |
| parent | ac103d45f63bd9a57ff867a52c7c95616f6daf51 (diff) | |
do fail on weakhash/loop earlier in acquire
The bugreport shows a segfault caused by the code not doing the correct
magical dance to remove an item from inside a queue in all cases. We
could try hard to fix this, but it is actually better and also easier to
perform these checks (which cause instant failure) earlier so that they
haven't entered queue(s) yet, which in return makes cleanup trivial.
The result is that we actually end up failing "too early" as if we
wouldn't be careful download errors would be logged before that process
was even started. Not a problem for the acquire system, but likely to
confuse users and programs alike if they see the download process
producing errors before apt was technically allowed to do an acquire
(it didn't, so no violation, but it looks like it to the untrained eye).
Closes: 835195
Diffstat (limited to 'test/integration/test-bug-605394-versioned-or-groups')
| -rwxr-xr-x | test/integration/test-bug-605394-versioned-or-groups | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/test/integration/test-bug-605394-versioned-or-groups b/test/integration/test-bug-605394-versioned-or-groups index a362463d5..43f35f79b 100755 --- a/test/integration/test-bug-605394-versioned-or-groups +++ b/test/integration/test-bug-605394-versioned-or-groups @@ -24,3 +24,7 @@ if aptget dist-upgrade --trivial-only -o Debug::pkgProblemResolver=1 -o Debug::p else msgpass fi + +# the Packages file includes only MD5 +testfailure aptget dist-upgrade -y +testsuccess grep 'Insufficient information available to perform this download securely' rootdir/tmp/testfailure.output |