diff options
| author | David Kalnischkies <david@kalnischkies.de> | 2018-05-04 18:24:57 +0200 |
|---|---|---|
| committer | David Kalnischkies <david@kalnischkies.de> | 2018-05-04 18:42:37 +0200 |
| commit | 1d77c915005f7630949e2ce706055ee3235009b6 (patch) | |
| tree | d10b246f29198a4085e2923a53e4d8bafff73bcc /test/libapt/fileutl_test.cc | |
| parent | 39d9e217a22901892647499ee695ba472a111d25 (diff) | |
Prevent GTest from flooding us with compiler warnings
GTest has a bunch of undefined macros which causes the compiler to spit
out warnings for each one on each test file. There isn't much we can do,
so we just disable the warning for the testcases. Other warnings like
sign-promo and sign-compare we can avoid by being more explicit about
our expected integer constants being unsigned.
As we are just changing testcases, there is no user visible change which
would deserve to be noted in the changelog.
Gbp-Dch: Ignore
Reported-By: gcc-8
Diffstat (limited to 'test/libapt/fileutl_test.cc')
| -rw-r--r-- | test/libapt/fileutl_test.cc | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/test/libapt/fileutl_test.cc b/test/libapt/fileutl_test.cc index 38536f77f..788ab76b2 100644 --- a/test/libapt/fileutl_test.cc +++ b/test/libapt/fileutl_test.cc @@ -49,7 +49,7 @@ static void TestFileFd(mode_t const a_umask, mode_t const ExpectedFilePermission EXPECT_TRUE(f.IsOpen()); EXPECT_FALSE(f.Failed()); EXPECT_FALSE(f.Eof()); - EXPECT_NE(0, f.FileSize()); + EXPECT_NE(0u, f.FileSize()); EXPECT_FALSE(f.Failed()); EXPECT_NE(0, f.ModificationTime()); EXPECT_FALSE(f.Failed()); @@ -96,7 +96,7 @@ static void TestFileFd(mode_t const a_umask, mode_t const ExpectedFilePermission EXPECT_FALSE(f.Failed()); EXPECT_FALSE(f.Eof()); EXPECT_N_STR(expect, readback); - EXPECT_EQ(7, f.Tell()); + EXPECT_EQ(7u, f.Tell()); } { APT_INIT_READBACK @@ -180,7 +180,7 @@ static void TestFileFd(mode_t const a_umask, mode_t const ExpectedFilePermission static void TestFileFd(unsigned int const filemode) { auto const compressors = APT::Configuration::getCompressors(); - EXPECT_EQ(8, compressors.size()); + EXPECT_EQ(8u, compressors.size()); bool atLeastOneWasTested = false; for (auto const &c: compressors) { @@ -204,7 +204,7 @@ TEST(FileUtlTest, FileFD) _config->Set("APT::Compressor::rev::Binary", "rev"); _config->Set("APT::Compressor::rev::Cost", 10); auto const compressors = APT::Configuration::getCompressors(false); - EXPECT_EQ(8, compressors.size()); + EXPECT_EQ(8u, compressors.size()); EXPECT_TRUE(std::any_of(compressors.begin(), compressors.end(), [](APT::Configuration::Compressor const &c) { return c.Name == "rev"; })); std::string const startdir = SafeGetCWD(); @@ -232,7 +232,7 @@ TEST(FileUtlTest, Glob) std::vector<std::string> files; // normal match files = Glob("*MakeLists.txt"); - EXPECT_EQ(1, files.size()); + EXPECT_EQ(1u, files.size()); // not there files = Glob("xxxyyyzzz"); @@ -241,7 +241,7 @@ TEST(FileUtlTest, Glob) // many matches (number is a bit random) files = Glob("*.cc"); - EXPECT_LT(10, files.size()); + EXPECT_LT(10u, files.size()); } TEST(FileUtlTest, GetTempDir) { @@ -296,7 +296,7 @@ TEST(FileUtlTest, Popen) EXPECT_TRUE(Popen(Args, Fd, Child, FileFd::ReadOnly)); EXPECT_TRUE(Fd.Read(buf, sizeof(buf)-1, &n)); buf[n] = 0; - EXPECT_NE(n, 0); + EXPECT_NE(n, 0u); EXPECT_STREQ(buf, "meepmeep\n"); // wait for the child to exit and cleanup |