summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorDavid Kalnischkies <david@kalnischkies.de>2016-06-08 13:44:29 +0200
committerDavid Kalnischkies <david@kalnischkies.de>2016-06-08 17:27:19 +0200
commit007d8b488787f4c33ced5937f22f99f1b759088a (patch)
treeee6d42146b4bc01b84c947e7755888a4dd1a1b45 /test
parent3a487cc03dec3488d0fa3008d04747bb1b4b0baf (diff)
edsp: drop privileges before executing solvers
Most (if not all) solvers should be able to run perfectly fine without root privileges as they get the entire state they are supposed to work on via stdin and do not perform any action directly, but just pass suggestions on via stdout. The new default is to run them all as _apt hence, but each solver can configure another user if it chooses/must. The security benefits are minimal at best, but it helps preventing silly mistakes (see 35f3ed061f10a25a3fb28bc988fddbb976344c4d) and that is always good. Note that our 'apt' and 'dump' solver already dropped privileges if they had them.
Diffstat (limited to 'test')
-rw-r--r--test/integration/framework4
1 files changed, 3 insertions, 1 deletions
diff --git a/test/integration/framework b/test/integration/framework
index ea577c04e..b7bee8a57 100644
--- a/test/integration/framework
+++ b/test/integration/framework
@@ -339,7 +339,9 @@ setupenvironment() {
# destroys coverage reporting though, so we disable changing user for the calling gpgv
echo "Dir::Bin::apt-key \"${BUILDDIRECTORY}/apt-key\";" >> aptconfig.conf
if [ "$(id -u)" = '0' ]; then
- echo 'Binary::gpgv::Debug::NoDropPrivs "true";' >>aptconfig.conf
+ echo 'Binary::gpgv::APT::Sandbox::User "root";' >> aptconfig.conf
+ # same for the solver executables
+ echo 'APT::Solver::RunAsUser "root";' >> aptconfig.conf
fi
cat > "${TMPWORKINGDIRECTORY}/rootdir/usr/bin/dpkg" <<EOF