summaryrefslogtreecommitdiff
path: root/vendor/steamos
diff options
context:
space:
mode:
authorDavid Kalnischkies <david@kalnischkies.de>2014-11-18 00:59:39 +0100
committerDavid Kalnischkies <david@kalnischkies.de>2014-11-28 16:15:39 +0100
commit299aea924ccef428219ed6f1a026c122678429e6 (patch)
tree4fb0f2fe7de3d697561e1fe1298c739ee4dea4fa /vendor/steamos
parent9fc0b435593839de47098212f0ae5f15b6263099 (diff)
fix PTY interaction on linux and kfreebsd
We run dpkg on its own pty, so we can log its output and have our own output around it (like the progress bar), while also allowing debconf and configfile prompts to happen. In commit 223ae57d468fdcac451209a095047a07a5698212 we changed to constantly reopening the slave for kfreebsd. This has the sideeffect though that in some cases slave and master will lose their connection on linux, so that no output is passed along anymore. We fix this by having always an fd referencing the slave open (linux), but we don't use it (kfreebsd). Failing to get our PTY up and running has many (bad) consequences including (not limited to, nor all at ones or in any case) garbled ouput, no output, no logging, a (partial) mixture of the previous items, … This commit is therefore also reshuffling quiet a bit of the creation code to get especially the output part up and running on linux and the logging for kfreebsd. Note that the testcase tries to cover some cases, but this is an interactivity issue so only interactive usage can really be a good test. Closes: 765687
Diffstat (limited to 'vendor/steamos')
0 files changed, 0 insertions, 0 deletions