summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-05-27use free() instead of delete() when realloc is usedMichael Vogt
ContentsExtract::~ContentsExtract() needs to use free() because Data got allocated via realloc() Reported-By: clang -fsanitize=address -fno-omit-frame-pointer
2014-05-27Merge remote-tracking branch 'upstream/debian/sid' into debian/sidMichael Vogt
2014-05-15Never parse Version/Architecture tags in a Translation-$lang fileMichael Vogt
Version/Architecture information in a Translation-$lang file is not allowed, so don't try to parse it. This is a fix for a bugreport where a Translation-en file contained the content of the regular Packages file (probably due to local FS corruption). This lead to strange error messages on file download. Thanks to Thomas Reusch for the report.
2014-05-08Merge remote-tracking branch 'mvo/feature/apt-ftparchive-srccache2' into ↵Michael Vogt
debian/sid
2014-05-08fix regression from commit 215b0fafMichael Vogt
2014-05-07show progress in run-testsMichael Vogt
2014-05-07Merge remote-tracking branch 'mvo/feature/apt-ftparchive-srccache2' into ↵Michael Vogt
debian/sid
2014-05-07Merge remote-tracking branch 'donkult/debian/sid' into debian/sidMichael Vogt
2014-05-05prepare release 1.0.31.0.3Michael Vogt
2014-05-05Revert "add bash completion for the "apt" command"Michael Vogt
This reverts commit 697c9314c8ba24f3e393b5de11a3fad7adae4bfc. Conflicts: debian/rules
2014-05-05Merge remote-tracking branch 'upstream/debian/sid' into debian/sidMichael Vogt
2014-04-30Only do openpty() if both stdin/stdout are terminalsMichael Vogt
Closes: 746434
2014-04-28initialize Verify in second pkgAcqIndex constructorDavid Kalnischkies
gcc reports in testcase ./test-bug-596498-trusted-unsigned-repo: apt-pkg/acquire-item.cc:1059:7: runtime error: load of value 234, which is not a valid value for type 'bool' This happens as the bool Verify is initialized only in one of the two constructors of the pkgAcqIndex class. It isn't a problem through as the verification controlled by this flag is optional and used to fail early on garbage files (like network portal pages) instead of later on in the hashsum verification or while parsing (the then untrusted) file. Reported-By: gcc-4.9 -fsanitize=undefined
2014-04-28Fix missing ScreenWidth check in apt.ccMichael Vogt
2014-04-28debian/apt-doc.docs: remove README.MultiArchMichael Vogt
2014-04-28l10n: vi.po: Update one new stringTrần Ngọc Quân
Signed-off-by: Trần Ngọc Quân <vnwildman@gmail.com>
2014-04-26allow vendors to install configuration filesDavid Kalnischkies
Vendors like ubuntu need to change some options, so giving them a way to do this less painfully avoids reducing differences.
2014-04-26fix FileFd::Size bitswap on big-endian architecturesAdam Conrad
gzip only gives us 32bit of size, storing it in a 64bit container and doing a 32bit flip on it has therefore unintended results. So we just go with a exact size container and let the flipping be handled by eglibc provided le32toh removing our #ifdef machinery. Closes: 745866
2014-04-26enforce LFS for partial files in https range requestsDavid Kalnischkies
2014-04-26remove unused duplicated acqprogress.{cc,h} filesDavid Kalnischkies
Those files are in apt-private and used from there. Git-Dch: Ignore
2014-04-26build http request in a stringstreamDavid Kalnischkies
beside reducing code a bit, it avoids oddball problems while building the string and doesn't trigger static analyse warnings.
2014-04-26remove outdated README.MultiArchDavid Kalnischkies
Debian wheezy shipped MultiArch to the masses and the predictions remained true in sofar as little changes in apt itself and many other frontends were needed compared to the fallout if done differently. The info included is this file is therefore no longer current and adds no useful information anymore, so we can drop it for good.
2014-04-26add a README for vendor informationDavid Kalnischkies
2014-04-26add vendor information for BlankOnMahyuddin Ramli
Modified by commiter to not publicily export the codename (as the manpages do not use it that way) and removing the included additional derives logic as it was not working (the link always exists at that point) and isn't needed as we do the special casing for debian mainly because it would shallow all distributions otherwise. (similar, but not that strong for ubuntu) Closes: 743595
2014-04-26handle pkgnames shorter than modifiersDavid Kalnischkies
The bugreport highlights the problem with an empty package name. We fix this by 'ignoring' these so that it behaves just like "apt-get install". The deeper problem is that modifier strings can be longer than a package name in which case the comparison doesn't make sense, so don't compare then. Was not noticed so far as all modifiers are of length 1, so the only package name shorter than this is in fact the empty package name. Closes: 744940
2014-04-26properly undo CD-ROM mount in all error casesJohn Ogness
In bug #740673 various issues in the CD-ROM handling code were identified, while most the issues ended up being fixed in another way, the unmounting of the CD-ROM in error cases was not tackled so far. (The patch was modified by the commiter to apply)
2014-04-25provide support for debian/apt.conf.$(lsb_release -i -s) vendor specific ↵Michael Vogt
config files
2014-04-25add bash completion for the "apt" commandMichael Vogt
2014-04-25reduce delta from ubuntuMichael Vogt
2014-04-25prepare release 1.0.21.0.2Michael Vogt
2014-04-22Merge remote-tracking branch 'upstream/debian/sid' into debian/sidMichael Vogt
2014-04-22Consistently use Dpkg::Progress* in documentationJames McCoy
Closes: 745452
2014-04-22Updated Thai program translation (closes: #745120)Theppitak Karoonboonyanan
2014-04-22Merge remote-tracking branch 'donkult/debian/sid' into debian/sidMichael Vogt
2014-04-22Fix option name DPkg::Progress-Fancy in apt.8 manpage (LP: #1310506)Michael Vogt
2014-04-22apt-private/acqprogress.cc: fix output when ctrl-c is hit during apt update ↵Michael Vogt
(LP: #1310548, closes: #744297)
2014-04-16support dist-upgrade options in full-upgradeDavid Kalnischkies
dist-upgrade is supposed to be an alias for full-upgrade in apt, but dist-upgrade was the only command recognized of the two in the option and flags recognition code.
2014-04-16extract travis installs from build-depends automaticallyDavid Kalnischkies
I forgot to add libgtest-dev to the list of packages to install on travis, so this slightly hacky oneliner might prevent us from having the same problem again if we happen to change dependencies again. Git-Dch: Ignore
2014-04-16use Google C++ Testing Framework for libapt testsDavid Kalnischkies
My commit 45df0ad2 from 26. Nov 2009 had a little remark: "The commit also includes a very very simple testapp." This was never intended to be permanent, but as usually… The commit adds the needed make magic to compile gtest statically as it is required and links it against a small runner. All previous testcase binaries are reimplemented in gtest and combined in this runner. While most code is a 1:1 translation some had to be rewritten like compareversion_test.cc, but the coverage remains the same.
2014-04-16clear HitEof flag in FileFd::SeekDavid Kalnischkies
fseek and co do this to their eof-flags and it is more logic this way as we will usually seek away from the end (e.g. to re-read the file). The commit also improves the testcase further and adds a test for the binary compressor codepath (as gz, bzip2 and xz are handled by libraries) via the use of 'rev' as a 'compressor'.
2014-04-16apt-private/acqprogress.cc: reset color in apt updateMichael Vogt
2014-04-14force fancy progressbar redraw on window size changeDavid Kalnischkies
We always reacted on the size change, but the bar is only redraw if the precentage changes, which can take quiet a while in big upgrades, so with a bit of refactoring we can now call for a redraw immediate to fix this. This refactor also helps in avoiding obscure pitfalls clangs static analyser was complaining about (namely failure of ioctl resulting in garbage values in the struct).
2014-04-13compile with absolute paths to allow lcov useDavid Kalnischkies
Instructing gcc (or clang) to prepare for capturing coverage data is easy: Just build with: CXXFLAGS=--coverage The hard part is that our buildsystem uses relative paths and so confuses the hell out of lcov as it assumes this way that all our *.cc files are in the same directory… by changing to absolute paths in the compile rules we solve this problem. Still not perfect as it refers to build/include files for most headers and our forking/threading code isn't properly captured, but good enough to see red reports for now: CXXFLAGS=--coverage make make test ./test/integration/run-tests -q lcov --no-external --directory . --capture --output-file apt.info genhtml --output-directory ./coverage/ apt.info Git-Dch: Ignore
2014-04-11l10n: vi.po (624t): Update translationTrần Ngọc Quân
Signed-off-by: Michael Vogt <mvo@debian.org>
2014-04-11Merge remote-tracking branch 'mvo/feature/helpful-apt-list' into debian/sidMichael Vogt
Conflicts: test/integration/test-apt-cli-list
2014-04-11Merge remote-tracking branch 'mvo/bugfix/apt-list-rc-pkgs' into debian/sidMichael Vogt
2014-04-11consider priorities only for downloadable pkgs in resolverDavid Kalnischkies
A package which can't be downloaded anymore is very likely dropped from a release and can therefore no longer be 'standard' (or similar). We therefore do not grant points for them anymore and demote them to prio:extra instead which helps other packages breaking them away even if they have a lower priority. The testcase was initially created by Michael Vogt and just amended.
2014-04-11extend FileFd test behond basic permission testsDavid Kalnischkies
We now do Open, Write and Read (the later multiple ways) for each permission and each compressor we have configured to cover more cases and especially ensure that compressors do not change our premissions. This test is also to be credited for discovering the skippos-fix. Git-Dch: Ignore
2014-04-11deal with umask only if we really need to for mkstempDavid Kalnischkies
As the comment actually says: open() does the umask dance by itself, so we don't need to do it for it. We have to do it after mkstemp in Atomic though, so move it into the if. Also removes the "micro-optimisation" "FilePermissions == 600" as it doesn't trigger at the moment anyway as 600 != 0600.
2014-04-11don't double-count seeks in FileFd::Skip for bzip/xzDavid Kalnischkies
FileFd::Read already deals with the increase of the skipposition so that we as the caller in FileFd::Skip really shouldn't increase it, too.