summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2013-08-22Merge remote-tracking branch 'donkult/debian/sid' into debian/sidMichael Vogt
2013-08-22apt-pkg:contrib Avoid compiler warning about sign-compareÁngel Guzmán Maeso
The fix avoid the warning "comparison between signed and unsigned integer expressions [-Wsign-compare]"· The index for the loop needs to be unsigned for compare with globbuf.gl_pathc structure member
2013-08-22Merge remote-tracking branch 'mvo/bugfix/coverity' into debian/sidMichael Vogt
Conflicts: apt-pkg/tagfile.h
2013-08-22Merge remote-tracking branch 'mvo/debian/sid' into debian/sidMichael Vogt
2013-08-22fix compiler warning about sign-compareAngel Guzman Maeso
This fix avoids the warning "comparison between signed and unsigned integer expressions [-Wsign-compare]". The index for the loop needs to be unsigned for compare with globbuf.gl_pathc structure member.
2013-08-22add versions to manpages-it Replaces+BreaksDavid Kalnischkies
In the meantime the package was updated to remove the old APT manpages from this package, so we can now add a Breaks and version it, too. The intial Replaces was added in: b57220d815aedbc023847d0885e08c6ed50e629a
2013-08-22add a breaks libapt-inst for FileFd changes in 0.9.9David Kalnischkies
Partial upgrades… The fix for 704608 assumes that bf35c19b817cc1474b3deabce0b0953c248bad42 was applied to libapt-inst which isn't the case for partial upgrades of course, so break it to ensure that it is the case. Closes: 720449
2013-08-19fix incorrect bugnumber for the Pre-Install-Pkgs hook (Closes: #671726)Michael Vogt
2013-08-19add lintian override for no-shlibs-control-file and only install ↵Michael Vogt
libapt-private.so.* instead libapt-private.so
2013-08-19Merge pull request #3 from cbaines/debian/sidMichael Vogt
Add test for bug 507998
2013-08-19prepare for releaseMichael Vogt
2013-08-17update changelogMichael Vogt
2013-08-17Merge remote-tracking branch 'mvo/feature/apt-binary2' into debian/sidMichael Vogt
Conflicts: cmdline/apt-get.cc
2013-08-17Merge remote-tracking branch 'donkult/debian/sid' into debian/sidMichael Vogt
2013-08-17Merge branch 'debian/sid' of git://git.debian.org/git/apt/apt into debian/sidChristian PERRIER
2013-08-17French translation update.Christian PERRIER
2013-08-16Add test for bug 507998Christopher Baines
2013-08-16allow Pre-Install-Pkgs hooks to get info over an FD != stdinDavid Kalnischkies
This adds ::InfoFD option alongside the ::Version one to request sending the information to the specified FD, by default it is STDIN as it was the case before. The environment variable APT_HOOK_INFO_FD contains the FD the data is on as a confirmation that the APT version used understood the request. Allowing the hook to choose the FD is needed/helpful e.g. for shellscripts which have a hard time accessing FDs above 9 (as >= 10 are usually used internally by them) Closes: #671728
2013-08-15use malloc instead of new[] in pkgTagFileDavid Kalnischkies
We don't need initialized memory for pkgTagFile, but more to the point we can use realloc this way which hides the bloody details of increasing the size of the buffer used. Git-Dch: Ignore
2013-08-15ensure that pkgTagFile isn't writing past Buffer lengthDavid Kalnischkies
In 91c4cc14d3654636edf997d23852f05ad3de4853 I removed the +256 from the pkgTagFile call parsing Release files as I couldn't find a mentioning of a reason for why and it was marked as XXX which suggested that at least someone else was suspicious. It turns out that it is indeed "documented", it just didn't found it at first but the changelog of apt 0.6.6 (29. Dec 2003) mentions: * Restore the ugly hack I removed from indexRecords::Load which set the pkgTagFile buffer size to (file size)+256. This is concealing a bug, but I can't fix it right now. This should fix the segfaults that folks are seeing with 0.6.[45]. The bug it is "hiding" is that if pkgTagFile works with a file which doesn't end in a double newline it will be adding it without checking if the Buffer is big enough to store them. Its also not a good idea to let the End pointer be past the end of our space, even if we don't access the data. Closes: 719629
2013-08-15set MALLOC_CHECK_ and MALLOC_PERTURB_ for testcasesDavid Kalnischkies
In bugreport deb:719629 Paul Wise mentions both to enable some malloc checks and as more testing can't hurt we enable both for all testcases. Git-Dch: Ignore
2013-08-15rework the parameter creation for the Hashsum testDavid Kalnischkies
Avoids having to different places from which test binaries are called Git-Dch: Ignore
2013-08-15do not call make from libapt/run-tests if its called by makeDavid Kalnischkies
If we are called by make everything is build already and so this is just a noise nop we can just skip. (Noisy as it complains about being unable to communicate with the other makes to coordinate with the jobserver) Git-Dch: Ignore
2013-08-15init the pkgTagFile with the size of the Release fileDavid Kalnischkies
Release files are basically one big Section, so we might safe some Resize circles by starting with the filesize. Git-Dch: Ignore
2013-08-15add PACKAGE_MATCHER_ABI_COMPAT mode for now so that this branch can be ↵Michael Vogt
merged without breaking ABI
2013-08-15* lp:~mvo/apt/add-glob-function:Michael Vogt
- add Glob() to fileutl.{cc,h} Conflicts: apt-pkg/contrib/fileutl.h debian/changelog
2013-08-15* lp:~mvo/apt/config-clear:Michael Vogt
- support Configuration.Clear() for a clear of the entire configuration Conflicts: debian/changelog
2013-08-15merge patch from Daniel Hartwig to Show a error message if {,dist-}upgrade ↵Michael Vogt
is used with additional arguments (closes: #705510)
2013-08-15merge patch from Daniel Hartwig to Clarify units of Acquire::http::Dl-Limit ↵Michael Vogt
(closes: #705445) Conflicts: debian/changelog
2013-08-15make destructors virtualMichael Vogt
2013-08-12really build apt.installMichael Vogt
2013-08-12install libapt-private* into the apt binaryMichael Vogt
2013-08-12Merge remote-tracking branch 'upstream/debian/sid' into feature/apt-binary2Michael Vogt
2013-08-12fix typo in the test for abi-compliance-checkerMichael Vogt
2013-08-12squash merge of the feature/apt-binary branch without the changes from ↵Michael Vogt
experimental
2013-08-12update changelog for upload0.9.10Michael Vogt
2013-08-12do not call 'apt-key update' in apt.postinstDavid Kalnischkies
The debian-archive-keyring package ships trusted.gpg.d fragment files for a while now and dropped their call to 'apt-key update', so there is no need for use to call it as the keys will always be available. This also finally allows a user to remove key(ring)s without APT to overriding this decision by readding them with this step. The functionality is kept around in the odd case that an old debian-archive-keyring package is used which still calls 'apt-key update' and depends on the import (hence, we also do not enforce a newer version of the debian-archive-keyring via our dependencies)
2013-08-12let apt-key del work better with softlink and single key keyringsDavid Kalnischkies
Having fragement files means there is a good chance that there is one key per keyring, so deal with that as well as with setups in which keyrings are linked into trusted.gpg.d as we can't just modify those files (they might be in /usr for example).
2013-08-12ensure that testcases exiting because of set -e aren't successfulDavid Kalnischkies
Git-Dch: Ignore
2013-08-12make the keyring locations in apt-key configurableDavid Kalnischkies
Might come in handy for more than just a simple testcase.
2013-08-12do not double-slash paths in apt-keyDavid Kalnischkies
Closes: 665411
2013-08-12use a tmpfile for trustdb.gpg in apt-keyDavid Kalnischkies
for some "interesting" reason gpg decides that it needs to update its trustdb.gpg file in a --list-keys command even if right before gpg is asked to --check-trustdb. That wouldn't be as bad if it wouldn't modify the keyring being listed at that moment as well, which generates not only warnings which are not a problem for us, but as the keyring modified can be in /usr it modified files which aren't allowed to be modified. The suggested solution in the bugreport is running --check-trustdb unconditionally in an 'apt-key update' call, but this command will not be used in the future and this could still potentially bite us in net-update or adv calls. All of this just to keep a file around, which we do not need… The commit therefore switches to the use of a temporary created trusted.gpg file for everyone and asks gpg to not try to update the trustdb after its intial creation, which seems to avoid the problem altogether. It is using your also faked secring btw as calling the check-trustdb without a keyring is a lot slower … Closes: #687611 Thanks: Andreas Beckmann for the initial patch!
2013-08-12always use our own trustdb.gpg in apt-keyDavid Kalnischkies
APT doesn't care for the trustdb.gpg, but gnupg requires one even for the simplest commands, so we either use the one root has available in /etc or if we don't have access to it (as only root can read that file) we create a temporary directory to store a trustdb.gpg in it. We can't create just a temporary file as gpg requires the given trustdb.gpg file to be valid (if it exists), so we would have to remove the file before calling gnupg which would allow mktemp (and co) to hand exactly this filename out to another program (unlikely, but still).
2013-08-12add a not documented apt-key --fakeroot optionDavid Kalnischkies
Usually, most apt-key commands require root, so the script is checking for being run as root, but in your tests we use a non-root location, so we don't need to be root and therefore need an option to skip the check. Git-Dch: Ignore
2013-08-12use our _error stack to generate openpty errorsDavid Kalnischkies
While we don't want these error messages on our usual stack, we can use our usual infrastructure to generate an error message with all the usual bells like errno and strerror attached. Git-Dch: Ignore
2013-08-12do not try to chown if not run as rootDavid Kalnischkies
If this code is run as non-root we are in a special situation (e.g. in our testcases) where it is obvious that we can't enforce user/group on any file, so skip this code altogether instead of bugging users with an error message – which we also switch to a warning as a failure to open the file is "just" a warning, so the 'wrong' owner shouldn't be that much of an issue. The file is still handled with chmod, so all the security we can enforce is still enforced of course, which also gets a warning if it fails. Git-Dch: Ignore
2013-08-12fix output redirection orderDavid Kalnischkies
First redirect output to a file, then redirect other outputs to this output, not the other way around as this will not work. Git-Dch: Ignore
2013-08-12fix: --print-uris removes authenticationDavid Kalnischkies
The constructors of our (clear)sign-acquire-items move a pre-existent file for error-recovery away, which gets restored or discarded later as the acquire progresses, but --print-uris never really starts the acquire process, so the files aren't restored (as they should). To fix this both get a destructor which checks for signs of acquire doing anything and if it hasn't the file is restored. Note that these virtual destructors theoretically break the API, but only with classes extending the sign-acquire-items and nobody does this, as it would be insane for library users to fiddle with Acquire internals – and these classes are internals. Closes: 719263
2013-08-12add chronic-like testsuccess/testfailure helpersDavid Kalnischkies
For many commands the output isn't stable (like then dpkg is called) but the exitcode is, so this helper enhances the common && msgpass || msgfail by generating automatically a msgtest and showing the output of the command in case of failure instead of discarding it unconditionally, the later being chronic-like behaviour Git-Dch: Ignore
2013-08-12test Release file handling with expired keysDavid Kalnischkies
Signing files with expired keys is not as easy as it sounds, so the framework jumps a few loops to do it, but it might come in handy to have an expired key around for later tests even if it is not that different from having no key in regards to APT behaviour. Git-Dch: Ignore