summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-04-16extract travis installs from build-depends automaticallyDavid Kalnischkies
I forgot to add libgtest-dev to the list of packages to install on travis, so this slightly hacky oneliner might prevent us from having the same problem again if we happen to change dependencies again. Git-Dch: Ignore
2014-04-16use Google C++ Testing Framework for libapt testsDavid Kalnischkies
My commit 45df0ad2 from 26. Nov 2009 had a little remark: "The commit also includes a very very simple testapp." This was never intended to be permanent, but as usually… The commit adds the needed make magic to compile gtest statically as it is required and links it against a small runner. All previous testcase binaries are reimplemented in gtest and combined in this runner. While most code is a 1:1 translation some had to be rewritten like compareversion_test.cc, but the coverage remains the same.
2014-04-16clear HitEof flag in FileFd::SeekDavid Kalnischkies
fseek and co do this to their eof-flags and it is more logic this way as we will usually seek away from the end (e.g. to re-read the file). The commit also improves the testcase further and adds a test for the binary compressor codepath (as gz, bzip2 and xz are handled by libraries) via the use of 'rev' as a 'compressor'.
2014-04-14force fancy progressbar redraw on window size changeDavid Kalnischkies
We always reacted on the size change, but the bar is only redraw if the precentage changes, which can take quiet a while in big upgrades, so with a bit of refactoring we can now call for a redraw immediate to fix this. This refactor also helps in avoiding obscure pitfalls clangs static analyser was complaining about (namely failure of ioctl resulting in garbage values in the struct).
2014-04-13compile with absolute paths to allow lcov useDavid Kalnischkies
Instructing gcc (or clang) to prepare for capturing coverage data is easy: Just build with: CXXFLAGS=--coverage The hard part is that our buildsystem uses relative paths and so confuses the hell out of lcov as it assumes this way that all our *.cc files are in the same directory… by changing to absolute paths in the compile rules we solve this problem. Still not perfect as it refers to build/include files for most headers and our forking/threading code isn't properly captured, but good enough to see red reports for now: CXXFLAGS=--coverage make make test ./test/integration/run-tests -q lcov --no-external --directory . --capture --output-file apt.info genhtml --output-directory ./coverage/ apt.info Git-Dch: Ignore
2014-04-11Merge remote-tracking branch 'mvo/feature/helpful-apt-list' into debian/sidMichael Vogt
Conflicts: test/integration/test-apt-cli-list
2014-04-11Merge remote-tracking branch 'mvo/bugfix/apt-list-rc-pkgs' into debian/sidMichael Vogt
2014-04-11consider priorities only for downloadable pkgs in resolverDavid Kalnischkies
A package which can't be downloaded anymore is very likely dropped from a release and can therefore no longer be 'standard' (or similar). We therefore do not grant points for them anymore and demote them to prio:extra instead which helps other packages breaking them away even if they have a lower priority. The testcase was initially created by Michael Vogt and just amended.
2014-04-11extend FileFd test behond basic permission testsDavid Kalnischkies
We now do Open, Write and Read (the later multiple ways) for each permission and each compressor we have configured to cover more cases and especially ensure that compressors do not change our premissions. This test is also to be credited for discovering the skippos-fix. Git-Dch: Ignore
2014-04-11deal with umask only if we really need to for mkstempDavid Kalnischkies
As the comment actually says: open() does the umask dance by itself, so we don't need to do it for it. We have to do it after mkstemp in Atomic though, so move it into the if. Also removes the "micro-optimisation" "FilePermissions == 600" as it doesn't trigger at the moment anyway as 600 != 0600.
2014-04-11don't double-count seeks in FileFd::Skip for bzip/xzDavid Kalnischkies
FileFd::Read already deals with the increase of the skipposition so that we as the caller in FileFd::Skip really shouldn't increase it, too.
2014-04-11do not create an (additional) empty compressorDavid Kalnischkies
FileFd code knows how to deal with such a compressor, so it isn't a problem, but it is absolutely not needed as we already have an (matching) identity compressor with '.' earlier in the list. Git-Dch: Ignore
2014-04-11be able to run abicheck from any directoryDavid Kalnischkies
Git-Dch: Ignore
2014-04-11use wildcard to get files in our library makefilesDavid Kalnischkies
The explicit listing is a pain every time you want to add a file to the list and serves no propose as we list all files there anyway, so this is not only easier but also documents this fact. Git-Dch: Ignore
2014-04-10fix test-failure in adtMichael Vogt
2014-04-10prepare 1.0.1 release1.0.1Michael Vogt
2014-04-10apt: Minor typo in 'apt' man page (closes: #743657)Josef Vitu
2014-04-10Merge remote-tracking branch 'mvo/bugfix/lp1304657-perms' into debian/sidMichael Vogt
2014-04-10Merge remote-tracking branch 'mvo/bugfix/apt-search-case' into debian/sidMichael Vogt
2014-04-10improve umask/fchmod code readabilityMichael Vogt
2014-04-10Rename FileFd::Open() Perms to AccessModeMichael Vogt
Bug lp:#1304657 was caused by confusion around the name Perms. The new name AccessMode should make it clear that its not the literal file permissions but instead the AccessMode passed to open() (i.e. the umask needs to be applied)
2014-04-10Fix insecure file permissions when using FileFd with OpenMode::AtomicMichael Vogt
Commit 7335eebea6dd43581d4650a8818b06383ab89901 introduced a bug that caused FileFd to create insecure permissions when FileFd::Atomic is used. This commit fixes the permissions and adds a test. The bug is most likely caused by the confusing "Perm" parameter that is passed to Open() - its not the file permissions but intead the "mode" part of open/creat.
2014-04-09Notice the user about "apt list -a" when only a single hit if foundMichael Vogt
If the user is using "apt list pattern" and there is only a single hit, notice about "--all-versions" as this is what the user may be interessted in
2014-04-09Fix possible race when stunnel/aptwebserver create their PID filesMichael Vogt
This patch should fix spurious test failures in jenkins or travis that are caused by a race condition in the {stunnel,aptwebserver}.pid file creation
2014-04-08fix apt list output for pkgs in dpkg ^rc stateMichael Vogt
Packages in the "deinstall ok config-file" have no candidate or instaleld version. So they must be special cased in the apt list generation.
2014-04-08Merge branch 'bugfix/apt-search-case' into debian/sidMichael Vogt
2014-04-07make apt search case-insensitive by defaultMichael Vogt
2014-04-07Add versioned openjdk-6-jdk breaksJulian Andres Klode
This helps if people did unclean upgrades from squeeze, namely to jessie directly.
2014-04-07Version the Breaks/Replaces for sun-java{5,6}-jdk (LP: #1302736)Julian Andres Klode
This is a *hack* to work around unofficial packages for Java 7 and 8 that wrongly provide the Java 5 and 6 packages. Closes: #743616
2014-04-04Fix crash in "apt list" when a sources.list file is unreableMichael Vogt
Closes: 743413
2014-04-01releasing package apt version 1.01.0Michael Vogt
2014-04-01add sun-java{5,6}-jdk to breaks/replaces as that provided a "apt" binary as wellMichael Vogt
2014-04-01install "apt" binary by defaultMichael Vogt
2014-04-01prepare releaseMichael Vogt
2014-04-01remove no longer needed apt.7 pageMichael Vogt
2014-04-01fix small apt.8.xml issuesMichael Vogt
2014-04-01refresh po/pot and unfuzzy apt-extracttemplate changeMichael Vogt
2014-04-01debian: Add default compress option to xzTrần Ngọc Quân
Signed-off-by: Trần Ngọc Quân <vnwildman@gmail.com>
2014-04-01l10n: vi.po (623t): Update Vietnamese translationTrần Ngọc Quân
Signed-off-by: Trần Ngọc Quân <vnwildman@gmail.com>
2014-04-01Merge remote-tracking branch 'mvo/feature/apt-manpage' into debian/sidMichael Vogt
Conflicts: cmdline/apt.cc
2014-04-01add "full-upgrade" to the apt.5.xml documentationMichael Vogt
2014-04-01Merge remote-tracking branch 'upstream/debian/sid' into feature/apt-manpageMichael Vogt
Conflicts: cmdline/apt.cc
2014-04-01Merge remote-tracking branch 'mvo/feature/more-fancy-progress' into debian/sidMichael Vogt
2014-04-01enable DPkg::Progress-Fancy by defaultMichael Vogt
2014-04-01Merge remote-tracking branch 'mvo/debian/sid' into debian/sidMichael Vogt
2014-04-01do not crash on SIGPIPE in pkgDPkgPM::RunScriptsWithPkgs()Michael Vogt
If a external command closes the PIPE unexpectedly, do not crash in pkgDPkgPM::RunScriptsWithPkgs but ignore the SIGPIPE.
2014-04-01Add new Debug::RunScripts optionMichael Vogt
This debug option will display all scripts that are run by apts RunScripts and RunScriptsWithPkgs helpers.
2014-03-27Merge branch 'debian/sid' into feature/more-fancy-progressMichael Vogt
2014-03-27Merge remote-tracking branch 'upstream/debian/sid' into debian/sidMichael Vogt
2014-03-27Use mkstemp() in apt-extracttemplaes (closes: #741627)Michael Vogt
Use mkstemp() in apt-extractemplates and add a integrationtest for apt-extracttemplates too. Thanks to Steve Kemp for the report.