summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-16policy: Add SetPriority() methodsJulian Andres Klode
These allow overriding priorities, however, pins set by SetPriority for package files will be overriden by calls to InitDefaults().
2020-02-13Merge branch 'tweak-man' into 'master'Julian Andres Klode
doc: remove "WIP" from apt.8.xml See merge request apt-team/apt!102
2020-02-13doc: remove "WIP" from apt.8.xmlMichael Vogt
The current man-page has "(work in progress") for `apt list`. I feel after more than >5y we can remove this.
2020-02-10seccomp: Allow recvmmsg_time64() and futex_time64()Julian Andres Klode
Saw those in libseccomp commit, figured should add them too.
2020-02-10debian/control: Bump libseccomp-dev Build-Depends to >= 2.4.2Julian Andres Klode
Version 2.4.2 is needed for the new syscalls we added to the whitelist.
2020-02-09seccomp: Allow time64 variants (>402,<415) of allowed syscallsJulian Andres Klode
Went through the list of syscalls starting at 403 (and looked one back) up to the next unknown syscalls, and added all those that were present in their non-time64 variant. Closes: #951012
2020-02-06Fix remaining usec vs sec time-delta calculation typosDavid Kalnischkies
While moving to a more stable clock in 79b61ae I typoed the microsecond calculation part and copied it all over the place… Julian fixed the first two instances in 089e6271 and Trent reported the apt-ftparchive instances leaving one instance in progress (invisible for user though). A bit ironic that in an attempt to stop "confusing (and amusing) users" I managed to hide a typo for close to two years doing just that… Sadly we can't really test this as while "apt-ftparchive generate /dev/null" is a great interactive test, it is hard to teach our test framework that the output is "reasonably below an hour" (usually 0s, but on busy test systems it is perhaps longer…). Thanks: Trent W. Buck for initial patch Closes: #950776 References: 79b61ae7673eb6213493e2cb202f0d70c390932d, 089e627153781ae7c320a5a0724c6c70d684b689
2020-02-04Release 1.9.9Julian Andres Klode
2020-02-04apt-patterns(7): Document | operator, (), and add an exampleJulian Andres Klode
Missed that in pu/short-patterns.
2020-02-03Merge branch 'pu/short-patterns' into 'master'Julian Andres Klode
Implement short patterns See merge request apt-team/apt!100
2020-02-03patterns: test for empty terms, reject themJulian Andres Klode
2020-02-03Correctly stop parsing short form arguments on space, also on ?Julian Andres Klode
we have to stop parsing on space so that things like ~ramd64 | ~rall work correctly. aptitude does not stop parsing on ?, but we'll do as it gets very confusing otherwise if you write stuff like ~ramd64?name(foo), and it resolves to ?and(?architecture(amd64?name), (foo))...
2020-02-03patterns: Implement parsing of (...) groupsJulian Andres Klode
2020-02-03Implement | as orJulian Andres Klode
2020-02-03patterns: Allow rendering patterns as patterns instead of json-ishJulian Andres Klode
2020-02-03apt-patterns(7): Some updates and rationaleJulian Andres Klode
2020-02-03patterns: Parse sequence of patterns as ?andJulian Andres Klode
2020-02-03patterns: Allow bare words only in argumentsJulian Andres Klode
This changes the syntax from approximately expr = unary unary = '!'? primary primary = pattern | short-pattern | word | quoted-word pattern = '?' name [ '(' expr [',' expr]* ')' ] short-pattern = ~ name | ~name expr to: primary = pattern | short-pattern argument = word | quoted-word | expr pattern = '?' name [ '(' argument [',' argument]* ')' ] short-pattern = ~ name | ~name argument
2020-02-03patterns: Implement unary !Julian Andres Klode
2020-02-03Implement short patterns (patterns starting with ~)Julian Andres Klode
Also make pattern detector in cacheset and private's list accept such patterns. We probably should just try to parse and see if it is a (start of a) pattern.
2020-02-03patterns: Use _sv literalsJulian Andres Klode
This will make it easier to extend those views, given that we do not need to hardcode their length.
2020-02-03patterns: Provide Node constructor, simplify error throwingJulian Andres Klode
By having a node constructor, we can construct a node inline for error reporting needs, simplifying the code a bit.
2020-02-03patterns: Make offset a size_t instead of off_tJulian Andres Klode
This allows comparing against sentence.size()
2020-02-03StringView: Implement operator ""_svJulian Andres Klode
This allows us to define constexpr string view literals.
2020-01-30Merge branch 'pu/wide-autoremove-kernel' into 'master'Julian Andres Klode
Widen regular expressions for versioned kernel packages See merge request apt-team/apt!59
2020-01-30Widen regular expressions for versioned kernel packagesJulian Andres Klode
Since we append a concrete kernel version to each pattern, and then anchor the pattern, let's just pick any package starting with a kernel name (linux-, kfreebsd-, gnumach-), and not worry about linux-headers, linux-tools, etc specifically, as they'll be caught by the generic pattern. LP: #1607845
2020-01-27Release 1.9.8Julian Andres Klode
2020-01-27NewGroup: Create GrpIterator after allocation (fix segfault)Julian Andres Klode
NewGroup created a GrpIterator and then called WriteStringInMap() which might remap the cache, causing the iterator to go invalid. Avoid this simply by creating the iterator later on.
2020-01-21apt-verbatim.ent: Update ubuntu-codename from disco to focalJulian Andres Klode
2020-01-17mmap: Do not look for empty pool unless we need toJulian Andres Klode
Given that we have a maximum of 12 pools, and much more items to insert, it does not make sense to have two branches in the hot path. Move the search for an empty pool into the unlikely case that no matching pool has been created yet - a condition that is guaranteed to only happens up to 12 times.
2020-01-16pkgcache.cc: Mix PACKAGE_VERSION into the cache hashJulian Andres Klode
This ensures that caches build with one version can't be opened with another, which makes sense. It's a temporary approach until we can replace major:minor fields with a version string. For example, this would have prevented 1.9.7 from using broken caches from 1.9.6.
2020-01-16Release 1.9.7Julian Andres Klode
2020-01-16Fix debian-rules-uses-deprecated-systemd-overrideJulian Andres Klode
We accidentally managed to restart apt-daily{,-upgrade}.service again because our dh_systemd_start override was being ignored since we switched to debhelper 12. Override dh_installsystemd instead. Gbp-Dch: full
2020-01-16NewProvidesAllArch: Check if group is empty before using itJulian Andres Klode
APT 1.9.6 introduced empty groups by making use of groups to deduplicate package names. This is not normally a problem, but here we assumed that every group has at least one package. This caused a problem because automake was providing automake-1.16 while having the source package automake-1.16. So we found the automake-1.16 group, iterated over its empty package list, trying to store the provides (which hence never happened). LP: #1859952
2020-01-15Trim trailing whitespace.Julian Andres Klode
Fixes: lintian: file-contains-trailing-whitespace See-also: https://lintian.debian.org/tags/file-contains-trailing-whitespace.html
2020-01-15Release 1.9.6Julian Andres Klode
2020-01-15Merge branch 'pu/apt-regex-cli' into 'master'Julian Andres Klode
apt(8): Disable regular expressions and fnmatch See merge request apt-team/apt!95
2020-01-15apt(8): Disable regular expressions and fnmatchJulian Andres Klode
This is the first step. Next step will be to add warnings to apt-get and then remove support there as well.
2020-01-15netrc: Add warning when ignoring entries for unencrypted protocolsJulian Andres Klode
Commit 93f33052de84e9aeaf19c92291d043dad2665bbd restricted auth.conf entries to only apply to https by default, but this was silent - there was no information why http sources with auth.conf entries suddenly started failing. Add such information, and extend test case to cover it.
2020-01-14Merge branch 'pu/gcrypt2' into 'master'Julian Andres Klode
Use Libgcrypt for hashing purposes See merge request apt-team/apt!89
2020-01-14Remove includes of (md5|sha1|sha2).h headersJulian Andres Klode
Remove it everywhere, except where it is still needed.
2020-01-14Deprecate the Summation classes and mark them for removalJulian Andres Klode
2020-01-14Convert users of {MD5,SHA1,SHA256,SHA512}Summation to use HashesJulian Andres Klode
This makes use of the a function GetHashString() that returns the specific hash string. We also need to implement another overload of Add() for signed chars with sizes, so the existing users do not require reinterpret_cast everywhere.
2020-01-14Raise buffer size for Hashes::AddFD() from 4 KiB to 64 KiBJulian Andres Klode
Move APT_BUFFER_SIZE to macros.h and re-use it in hashes, this also might speed up stuff, the motivation for using 64 KiB buffers in fileutl.cc was precisely that after all.
2020-01-14hashes: Use Libgcrypt for hashing purposesJulian Andres Klode
Switch the code of the Hashes class to use libgcrypt, which allows us to use hardware-accelerated implementations of SHA1 and friends.
2020-01-09Merge branch 'pu/source-groups' into 'master'Julian Andres Klode
Avoid extra out-of-cache hash table deduplication for package names See merge request apt-team/apt!92
2020-01-08acquire: Move queue startup after calling log's Start()Julian Andres Klode
Startup() was checking for bad items and failing them, but we did not actually call Start() in the log, so the log might not be setup correctly. This caused a crash in python-apt when items were being failed on queue startup, as it released the GIL when Start() is being called and re-acquires it when running callbacks.
2020-01-08Avoid extra out-of-cache hash table deduplication for package namesJulian Andres Klode
We were de-duplicating package name strings in StoreString, but also deduplicating most of them by them being in groups, so we had extra hash table lookups that could be avoided in NewGroup(). To continue deduplicating names across binary packages and source packages, insert groups for source packages as well. This is also a good first step in allowing efficient lookup of packages by source package - we can extend Group later by a list of SourceVersion objects, or alternatively, simply add a by-source chain into pkgCache::Version. This change improves performance by about 10% (913 to 814 ms), while having no significant overhead on the cache size: --- before +++ after @@ -1,7 +1,7 @@ -Total package names: 109536 (2.191 k) -Total package structures: 118689 (4.748 k) +Total package names: 119642 (2.393 k) +Total package structures: 118687 (4.747 k) Normal packages: 83309 - Pure virtual packages: 3365 + Pure virtual packages: 3363 Single virtual packages: 17811 Mixed virtual packages: 1973 Missing: 12231 @@ -10,21 +10,21 @@ Total distinct descriptions: 149291 (3.583 k) Total dependencies: 484135/156650 (12,2 M) Total ver/file relations: 57421 (1.378 k) Total Desc/File relations: 18219 (437 k) -Total Provides mappings: 29963 (719 k) +Total Provides mappings: 29959 (719 k) Total globbed strings: 226993 (5.332 k) Total slack space: 26,8 k -Total space accounted for: 38,1 M +Total space accounted for: 38,3 M Total buckets in PkgHashTable: 50503 - Unused: 5727 - Used: 44776 - Utilization: 88.6601% - Average entries: 2.65073 + Unused: 5728 + Used: 44775 + Utilization: 88.6581% + Average entries: 2.65074 Longest: 60 Shortest: 1 Total buckets in GrpHashTable: 50503 - Unused: 5727 - Used: 44776 - Utilization: 88.6601% - Average entries: 2.44631 - Longest: 10 + Unused: 4649 + Used: 45854 + Utilization: 90.7946% + Average entries: 2.60919 + Longest: 11 Shortest: 1
2020-01-07Merge branch 'pu/macro-cleanup' into 'master'Julian Andres Klode
Pu/macro cleanup See merge request apt-team/apt!91
2020-01-07Only define likely/unlikely if APT_COMPILING_APT setJulian Andres Klode
This ensures that we do not leak simple words like that.