| Age | Commit message (Collapse) | Author |
|---|
|
In the intended usecase where this serves as a hack there is no problem
with double/single quotes being present as we write it to a log file
only, but nowadays our calling of apt-key produces a temporary config
file containing this "setting" as well and suddently quoting is
important as the config file syntax is allergic to it.
So the fix is to ignore all quoting whatsoever in the input and just
quote (with singles) the option values with spaces. That gives us 99% of
the time the correct result and the 1% where the quote is an integral
element of the option … doesn't exist – or has bigger problems than a
log file not containing the quote. Same goes for newlines in values.
LP: #1672710
(cherry picked from commit 2ce15bdeac6ee93faefd4b42b57f035bef80c567)
(cherry picked from commit c75620dcfa749f8030e0180df44eec746402885d)
|
|
space-gapping: '-o option= value'
That is a very old feature (straight from 1998), but it is super
surprising if you try setting empty values and instead get error
messages or a non-empty value as the next parameter is treated as the
value – which could have been empty, so if for some reason you need a
compatible way of setting an empty value try: '-o option="" ""'.
I can only guess that the idea was to support '-o option value', but we
survived 17 years without it, we will do fine in the future I guess.
Similar is the case for '-t= testing' even through '-t testing' existed
before and the code even tried to detect mistakes like '-t= -b' … all
gone now.
Technically that is as its removing a feature replacing it with another
a major interface break. In practice I really hope for my and their
sanity that nobody was using this; but if for some reaon you do: Remove
the space and be done.
I found the patch and the bugreport actually only after the fact, but
its reassuring that others are puzzled by this as well and hence a
thanks is in perfect order here as the patch is practical identical
[expect that this one here adds tests and other bonus items].
Thanks: Daniel Hartwig for initial patch.
Closes: 693092
|
|
Its not as simple as I initially thought to abstract this enough to make
it globally usable, so lets not pollute global namespace with this for
now.
Git-Dch: Ignore
|
|
All mains pretty much do the same thing, so lets try a little harder to
move the common parts into -private to have the real differences more
visible.
Git-Dch: Ignore
|
|
That is one huge commit with busy work only: Help messages used to be
one big translateable string, which is a pain for translators and hard
to reuse for us. This change there 'explodes' this single string into
new string for each documented string trying hard to split up the
translated messages as well. This actually restores many translations as
previously adding a single command made all of the bug message fuzzy.
The splitup also highlighted that its easy to forget a line, duplicate
one and similar stuff.
Git-Dch: Ignore
|
|
Gbp-Dch: ignore
|
|
Closes: #762758
|
|
By convention, if I run a tool with --help or --version I expect it to
exit successfully with the usage, while if I do call it wrong (like
without any parameters) I expect the usage message shown with a non-zero
exit.
|
|
This used to work before we implemented a stricter commandline parser
and e.g. the dd-schroot-cmd command constructs commandlines like this.
Reported-By: Helmut Grohne
|
|
Beside being a bit cleaner it hopefully also resolves oddball problems
I have with high levels of parallel jobs.
Git-Dch: Ignore
Reported-By: iwyu (include-what-you-use)
|
|
|
|
Conflicts:
apt-pkg/tagfile.h
|
|
experimental
|
|
|
|
|
|
- apply patch from Daniel Hartwig to fix a segfault in case
the LongOpt is empty (Closes: #676331)
|
|
|
|
|
|
|
|
|
|
- fix segfault in SaveInConfig caused by writing over char[] sizes
|
|
- if available store the Commandline in the history
* apt-pkg/contrib/cmndline.cc:
- save Commandline in Commandline::AsString for logging
|
|
|
|
|
|
Author: doogie
Date: 2003-02-10 01:40:58 GMT
Typo fixes.
|
|
Author: doogie
Date: 2002-11-11 06:55:50 GMT
Some more g++-3.2 fixes.
|
|
Author: jgg
Date: 2002-09-14 05:28:38 GMT
PD license
|
|
Author: jgg
Date: 2001-06-09 22:39:48 GMT
Fixed -- argument bug
|
|
Author: jgg
Date: 2001-02-20 07:03:16 GMT
Join with aliencode
|
|
Author: jgg
Date: 1999-05-14 02:57:48 GMT
Changed handling of the -q option
|
|
Author: jgg
Date: 1999-01-27 02:48:52 GMT
Moved strutl.h
|
|
Author: jgg
Date: 1999-01-18 06:20:07 GMT
Dsync merge
|
|
Author: jgg
Date: 1998-12-14 02:23:46 GMT
Release support
|
|
Author: jgg
Date: 1998-11-25 23:54:06 GMT
More CD support
|
|
Author: jgg
Date: 1998-10-24 20:14:34 GMT
Fixed long option parsing
|
|
Author: jgg
Date: 1998-10-20 02:39:12 GMT
Start on acquire stuff
|
|
Author: jgg
Date: 1998-10-08 04:54:58 GMT
Sync
|
|
Author: jgg
Date: 1998-09-26 05:34:18 GMT
Sync
|
|
Author: jgg
Date: 1998-09-22 05:30:24 GMT
Sync
|
