| Age | Commit message (Collapse) | Author |
|---|
|
Improve locking messaging - pid and name, "do not remove lock file"
See merge request apt-team/apt!68
|
|
Also in old changelogs, but nothing really user visible
like error messages or alike so barely noteworthy.
Reported-By: codespell
Gbp-Dch: Ignore
|
|
Reported-By: cppcheck
|
|
The error messages say only which package it was trying to provide, but
not which package & version tried it which can be misleading as to which
package (version) is the offender.
References: #930256
|
|
Work like applying patches via rred can be performed by many concurrent
rred processes, but we can't just spawn new ones forever: We limit us to
the number of CPUs which can drive them and reuse existing ones if they
have nothing to do at the moment.
The problem arises if we have reached the limit of queues and all of
them are busy which is more likely to happen on "slow" machines with few
CPUs. In this case we opted for random distribution, but that can result
in many big files (e.g. Contents) being added to one queue while the
others get none or only small files.
Ideally we would ask the methods how much they still have to do, but
they only know that for the current item, not for all items in the
queue, so we use the filesize of the expected result.
|
|
We want to tell users which process is holding the lock so they
can easily understand what's going on, and we want to advise
users not to remove the lock file, because ugh, that's bad.
Re-initalize the flock structure, in case it got mangled by
previous fcntl call.
|
|
We are converting to std::string anyway by passing to
istringstream, and this removes the need for .c_str()
in callers.
|
|
Gbp-Dch: ignore
|
|
These functions do not produce any useful results anymore, so
it's pointless to keep them around.
|
|
This mostly turns them private and then overrides the public
version with the switch, as recommended.
|
|
1.6 was 13, so 1.7 has 14 reserved, and 1.8 has 15 reserved, so
let's use 16 for 1.9 for now.
|
|
|
|
|
|
LP: #1756595
Fixes Debian/apt#94
|
|
Gbp-Dch: ignore
|
|
|
|
|
|
|
|
apt Debian release 1.8.2
|
|
We need to unlock in the reverse order of locking in order
to get useful behavior.
LP: #1829860
|
|
Using the locale-dependent isspace() function here opens us up
to strange locale-dependent behavior.
|
|
This ensures that we do not accidentally stop overriding a
method because it's signature changed in an API break.
|
|
This is a bit experimental, and we'll go through a few stages
before reaching libapt-pkg.so.6.0.
|
|
This is missing the ones that are still actively used in
cacheset.cc, we need to clean those up too, but they are
obviously more tricky.
|
|
|
|
|
|
As long as we are running dpkg, keep an inhibitor that
blocks us from shutting down.
LP: #1820886
|
|
As long as we are running dpkg, keep an inhibitor that
blocks us from shutting down.
LP: #1820886
|
|
This needs a fair amount of changes elsewhere in the code,
hence this is separate from the previous commits.
|
|
This avoids funny code where strings get implicitly converted to
HashString or HashStringList.
|
|
This prevents implicit conversions that we do not want, such
as having a FileFd* being converted to a debListParser.
Two cases are not yet handled because they require changes
in code using them:
1. The classes in hashes.h
2. The URI class - this one is used quite a lot
|
|
These status fields belong to the current item, move them there. This
prepares us for eventually having multiple current items.
|
|
Queues for processes like rred are not created by hostname but we
spawn at most CPU*2 queues to place items in. The problem is that we
then proceeded to limit it to at most 10 queues (via QueueHost::Limit)
again at the end of the method so that all items (after the first 10
queues are busy) are forcibly placed into a generic catch-all instance
which is bad because we don't keep all CPUs we have available busy and
worse we end up sheduling the most work to a single one while random
distribution was intended.
|
|
warning: but ‘pkgTagFilePrivate::FileChunk::FileChunk(bool, size_t)’
does not throw; perhaps it should be declared ‘noexcept’ [-Wnoexcept]
Reported-By: gcc-9
Gbp-Dch: Ignore
|
|
Add PkgConfig on the apt-pkg and apt-inst libraries
See merge request apt-team/apt!20
|
|
|
|
Closes: #439121
|
|
apt Debian release 1.8.0
|
|
Verifying the content of Release.gpg made us fail on binary signatures
which were never officially supported (apt-secure manpage only documents
only the generation of ASCII armored), but silently accepted by gpgv as
we passed it on unchecked before.
The binary format is complex and is itself split into old and new
formats so adding support for this would not only add lots of code but
also a good opportunity for bugs and dubious benefit.
Reporting this issue explicitly should help repository creators figure
out the problem faster than the default NODATA message hinting at
captive portals.
Given that the binary format has no file magic or any other clear and
simple indication that this is a detached signature we guess based on
the first two bits only – and by that only supporting the "old" binary
format which seems to be the only one generated by gnupg in this case.
References: e2965b0b6bdd68ffcad0e06d11755412a7e16e50
Closes: #921685
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Please use the standard C++ variants instead.
|
|
|
|
|
|
|
