summaryrefslogtreecommitdiff
path: root/apt-pkg
AgeCommit message (Collapse)Author
2019-04-16Don't limit cpu-limited queues to at most 10David Kalnischkies
Queues for processes like rred are not created by hostname but we spawn at most CPU*2 queues to place items in. The problem is that we then proceeded to limit it to at most 10 queues (via QueueHost::Limit) again at the end of the method so that all items (after the first 10 queues are busy) are forcibly placed into a generic catch-all instance which is bad because we don't keep all CPUs we have available busy and worse we end up sheduling the most work to a single one while random distribution was intended.
2019-04-16Follow gcc-9 -Wnoexcept suggestion for FileChunk constructorDavid Kalnischkies
warning: but ‘pkgTagFilePrivate::FileChunk::FileChunk(bool, size_t)’ does not throw; perhaps it should be declared ‘noexcept’ [-Wnoexcept] Reported-By: gcc-9 Gbp-Dch: Ignore
2019-04-04Merge branch 'pkgconfig' into 'master'Julian Andres Klode
Add PkgConfig on the apt-pkg and apt-inst libraries See merge request apt-team/apt!20
2019-03-11Use system-provided triehashJulian Andres Klode
2019-03-08Add pkg-config files for the apt-pkg and apt-inst librariesCorentin Noël
Closes: #439121
2019-03-08Merge tag '1.8.0'Julian Andres Klode
apt Debian release 1.8.0
2019-03-03Add explicit message for unsupported binary signatureDavid Kalnischkies
Verifying the content of Release.gpg made us fail on binary signatures which were never officially supported (apt-secure manpage only documents only the generation of ASCII armored), but silently accepted by gpgv as we passed it on unchecked before. The binary format is complex and is itself split into old and new formats so adding support for this would not only add lots of code but also a good opportunity for bugs and dubious benefit. Reporting this issue explicitly should help repository creators figure out the problem faster than the default NODATA message hinting at captive portals. Given that the binary format has no file magic or any other clear and simple indication that this is a detached signature we guess based on the first two bits only – and by that only supporting the "old" binary format which seems to be the only one generated by gnupg in this case. References: e2965b0b6bdd68ffcad0e06d11755412a7e16e50 Closes: #921685
2019-02-26fileutl: Merge Popen variantsJulian Andres Klode
2019-02-26acquire-item: Remove deprecated members and functionsJulian Andres Klode
2019-02-26orderlist: Remove deprecated VisitNode() variantJulian Andres Klode
2019-02-26dpkgpm: Remove deprecated pkgDPkgPM::SendV2Pkgs()Julian Andres Klode
2019-02-26fileutl: Remove deprecated functions such as gzFd()Julian Andres Klode
2019-02-26strutl: Remove deprecated functionsJulian Andres Klode
2019-02-26edsp: Remove deprecated functionsJulian Andres Klode
2019-02-26sptr: Remove deprecated smart pointer classesJulian Andres Klode
Please use the standard C++ variants instead.
2019-02-26sourceslist: Remove deprecated AddVolatileFiles() variantJulian Andres Klode
2019-02-26netrc: Remove deprecated function maybe_add_auth()Julian Andres Klode
2019-02-26depcache: Remove deprecated functionsJulian Andres Klode
2019-02-26packagemanager: Remove deprecated functionsJulian Andres Klode
2019-02-26pkgcachegen: Remove deprecated functionsJulian Andres Klode
2019-02-26indexcopy: Remove deprecated SigVerify::RunGPGV()Julian Andres Klode
2019-02-26hashes: Remove deprecated functionsJulian Andres Klode
This keeps the members in the class, but makes them private. We want to migrate to libgcrypt eventually, since we already use libgcrypt through gpgv anyway.
2019-02-26metaindex: Remove deprecated checkSum::Hash (replaced by Hashes)Julian Andres Klode
2019-02-26algorithms: Remove deprecated ProblemResolver::InstallProtect()Julian Andres Klode
2019-02-26acquire: Remove deprecated pkgAcquire::Setup() functionJulian Andres Klode
2019-02-26acquire: Fold pkgAcquireStatus2 into pkgAcquireStatusJulian Andres Klode
Clean up the code, make it neat, lalala
2019-02-26tagfile: Remove deprecated pkgUserTagSection and TFRewriteJulian Andres Klode
2019-02-26indexfile: Remove deprecated translation functionsJulian Andres Klode
2019-02-26clean: Fold pkgArchiveCleaner2 into pkgArchiveCleanerJulian Andres Klode
2019-02-26pkgSrcRecords::Parser: Fold Files2() into Files()Julian Andres Klode
This is possible now with the API break. Cleaner code, woohoo.
2019-02-26pkgrecords: Renive deprecated functionsJulian Andres Klode
2019-02-26cachefile: Remove deprecated functionsJulian Andres Klode
2019-02-26upgrade: Remove deprecated functionsJulian Andres Klode
2019-02-26cacheiterators: Cleanup deprecated codeJulian Andres Klode
2019-02-26pkgcache: Remove deprecated bitsJulian Andres Klode
2019-02-26Bump SONAMEs in preparation for ABI breaksJulian Andres Klode
2019-02-10Fix various typos in the documentationJakub Wilk
2019-02-04Use std::to_string() for HashStringList::FileSize() getterJulian Andres Klode
This slightly improves performance, as std::to_string() (as in gcc's libstdc++) avoids a heap allocation. This is surprisingly performance critical code, so we might want to improve things further in 1.9 by manually calculating the string - that would also get rid of issues with locales changing string formatting, if any.
2019-02-04Detect function multiversioning and sse4.2/crc32, enables i386Julian Andres Klode
This fixes the build on kfreebsd-amd64, and due to the detection of sse4.2, should also enable the sse4.2 on i386.
2019-02-04gpgv: Use buffered writes for splitting clearsigned filesJulian Andres Klode
This is safe here, as the code ensures that the file is flushed before it is being used. The next series should probably make GetTempFile() buffer writes by default.
2019-02-04Merge branch 'pu/dead-pin' into 'master'Julian Andres Klode
A pin of -32768 overrides any other, disables repo See merge request apt-team/apt!40
2019-02-01Add a Packages-Require-Authorization Release file fieldJulian Andres Klode
This new field allows a repository to declare that access to packages requires authorization. The current implementation will set the pin to -32768 if no authorization has been provided in the auth.conf(.d) files. This implementation is suboptimal in two aspects: (1) A repository should behave more like NotSource repositories (2) We only have the host name for the repository, we cannot use paths yet. - We can fix those after an ABI break. The code also adds a check to acquire-item.cc to not use the specified repository as a download source, mimicking NotSource.
2019-02-01Introduce experimental 'never' pinning for sourcesJulian Andres Klode
This allows disabling a repository by pinning it to 'never', which is internally translated to a value of -32768 (or whatever the minimum of short is). This overrides any other pin for that repository. It can be used to make sure certain sources are never used; for example, in unattended-upgrades. To prevent semantic changes to existing files, we substitute min + 1 for every pin-priority: <min>. This is a temporary solution, as we are waiting for an ABI break. To add pins with that value, the special Pin-Priority "never" may be used for now. It's unclear if that will persist, or if the interface will change eventually.
2019-02-01Merge branch 'pu/refuseunsignedlines' into 'master'Julian Andres Klode
Fail if InRelease or Release.gpg contain unsigned lines See merge request apt-team/apt!45
2019-02-01Step over empty sections in TagFiles with commentsDavid Kalnischkies
Implementing a parser with recursion isn't the best idea, but in practice we should get away with it for the time being to avoid needless codechurn. Closes: #920317 #921037
2019-02-01Drop buffered writing from clearsigned message extractionDavid Kalnischkies
It is dropped in the merged code, but the extraction of the clearsigned message code was the only one who had it previously, so the short-desc explains the change from a before-after merge of the branch PoV. It would make sense to enable it, but as we aren't in a time critical paths here we can delay this for after buster to avoid problems. References: 73e3459689c05cd62f15c29d2faddb0fc215ef5e Suggested-By: Julian Andres Klode
2019-02-01Avoid boolean flags by splitting writeTo functionsDavid Kalnischkies
Suggested-By: Julian Andres Klode Gbp-Dch: Ignore
2019-01-31Merge branch 'pu/verify-method-messages-2' into 'master'Julian Andres Klode
Verify data being sent by methods in SendMessage() See merge request apt-team/apt!48
2019-01-31Disable deprecated methods (ftp, rsh, ssh) by defaultJulian Andres Klode
These methods are not supposed to be used anymore, they are not actively maintained and may hence contain odd bugs. Fixes !49
2019-01-30Verify data being sent by methods in SendMessage()Julian Andres Klode
As a follow-up for CVE-2019-3462, add checks similar to those for redirect to the central SendMessage() function. The checks are a bit more relaxed for values - they may include newlines and unicode characters (newlines get rewritten, so are safe). For keys and the message header, the checks are far more strict: They may only contain alphanumerical characters, the hyphen-minus, and the horizontal space. In case the method tries to send anything else, we construct a legal 400 URI Failed response, and send that. We specifically do not include the item URI, in case it has been compromised (that would cause infinite recursion).