summaryrefslogtreecommitdiff
path: root/cmdline
AgeCommit message (Collapse)Author
2013-08-17Merge remote-tracking branch 'mvo/feature/apt-binary2' into debian/sidMichael Vogt
Conflicts: cmdline/apt-get.cc
2013-08-15merge patch from Daniel Hartwig to Show a error message if {,dist-}upgrade ↵Michael Vogt
is used with additional arguments (closes: #705510)
2013-08-12squash merge of the feature/apt-binary branch without the changes from ↵Michael Vogt
experimental
2013-08-12let apt-key del work better with softlink and single key keyringsDavid Kalnischkies
Having fragement files means there is a good chance that there is one key per keyring, so deal with that as well as with setups in which keyrings are linked into trusted.gpg.d as we can't just modify those files (they might be in /usr for example).
2013-08-12make the keyring locations in apt-key configurableDavid Kalnischkies
Might come in handy for more than just a simple testcase.
2013-08-12do not double-slash paths in apt-keyDavid Kalnischkies
Closes: 665411
2013-08-12use a tmpfile for trustdb.gpg in apt-keyDavid Kalnischkies
for some "interesting" reason gpg decides that it needs to update its trustdb.gpg file in a --list-keys command even if right before gpg is asked to --check-trustdb. That wouldn't be as bad if it wouldn't modify the keyring being listed at that moment as well, which generates not only warnings which are not a problem for us, but as the keyring modified can be in /usr it modified files which aren't allowed to be modified. The suggested solution in the bugreport is running --check-trustdb unconditionally in an 'apt-key update' call, but this command will not be used in the future and this could still potentially bite us in net-update or adv calls. All of this just to keep a file around, which we do not need… The commit therefore switches to the use of a temporary created trusted.gpg file for everyone and asks gpg to not try to update the trustdb after its intial creation, which seems to avoid the problem altogether. It is using your also faked secring btw as calling the check-trustdb without a keyring is a lot slower … Closes: #687611 Thanks: Andreas Beckmann for the initial patch!
2013-08-12always use our own trustdb.gpg in apt-keyDavid Kalnischkies
APT doesn't care for the trustdb.gpg, but gnupg requires one even for the simplest commands, so we either use the one root has available in /etc or if we don't have access to it (as only root can read that file) we create a temporary directory to store a trustdb.gpg in it. We can't create just a temporary file as gpg requires the given trustdb.gpg file to be valid (if it exists), so we would have to remove the file before calling gnupg which would allow mktemp (and co) to hand exactly this filename out to another program (unlikely, but still).
2013-08-12add a not documented apt-key --fakeroot optionDavid Kalnischkies
Usually, most apt-key commands require root, so the script is checking for being run as root, but in your tests we use a non-root location, so we don't need to be root and therefore need an option to skip the check. Git-Dch: Ignore
2013-08-12improve error messageMichael Vogt
2013-08-08fix -Wall errorsMichael Vogt
2013-08-01unset LANGUAGE for showing [Y/n] answer hintsDavid Kalnischkies
nl_langinfo is used to acquire the YESEXPR of the language used, but it will return the one from LC_MESSAGES, which might be different from the language chosen for display of the question (based on LANGUAGE) so this commit removes the [Y/n] help text from the questions itself and moves it to the prompt creation in which the usage of LC_MESSAGES is forced for it, so that the helptext shown actually represents the characters accepted as input for the question. There is still room for problems of course starting with an untranslated "[Y/n]" but a translated YESEXPR or the problem that the question is asked in a completely different language which might have a conflicting definition of [Y/n] input or the user simple ignores the helptext and assumes that an answer matching the question language is accepted, but the mayority of users will never have this problem to begin with, so we should be fine (or at least a bit finer than before). Closes nothing really, but should at least help a bit with bugs like deb:194614, deb:471102, lp:1205578, and countless others.
2013-07-28Merge remote-tracking branch 'mvo/bugfix/coverity' into debian/sidMichael Vogt
2013-07-26fix some coverity chroot() releated warningsMichael Vogt
2013-07-26use FileFd::Write instead of fwrite for errorsDavid Kalnischkies
Using the static FileFd::Write method gives us error messages for free so we use it here to avoid failing silently (with a fail silent error). Git-Dch: Ignore
2013-07-25fix potential GetLock() fd leakMichael Vogt
2013-07-18fix 'apt-cache search' crash with missing descriptionDavid Kalnischkies
Beside the earlier fixed 'apt-cache show', 'showpkg' and 'search' deal with descriptions. 'showpkg' was fixed by fixing the cache generation for 'show', but 'search' still segfaulted. On the upside, it doesn't segfault any longer, on the downside, if a package has no description at all (aka: not in the Packages file and not in a Translation-* file) the package can't be found with 'search', even if we search only by name. That is a shortcoming in the code, but fixing it means rewriting it completely for dubious gain at best. So this commit just skips packages without a description and is done. Closes: 647590
2013-07-18skip all Description fields in apt-cache, not just firstDavid Kalnischkies
Given a Packages file like: […] Description: foo bar baz moo moo moo Multi-Arch: foreign Description-md5: 97e204a9f4ad8c681dbd54ec7c505251 […] We have to display the Multi-Arch flag field as well as the fields after the Description-md5, but not this field itself, as we already have one printed alongside the Description we display. Closes: 717254
2013-07-02fix format string errorMichael Vogt
2013-06-26"mount path"->"mount point" and also make the warning a error when no CD-ROM ↵Michael Vogt
is found
2013-06-22Improve the apt-cdrom output when no CD-ROM can be auto-detectedMichael Vogt
(closes: #712433)
2013-06-20try defaults if auto-detection failed in apt-cdromDavid Kalnischkies
The default is to ask udev for location and mountpoints of CD-ROMs, but the old way of specifying the mountpoint is still available and is tried now in case udev doesn't find any CD-ROM. It probably fails, too, but we get a bunch of error messages this way and the user can get an idea of how to make his setup work even if udev can't be convienced to return something useful. Closes: #712433
2013-06-20handle missing "Description" in apt-cache showDavid Kalnischkies
do not blindly assume that all packages stanzas have a "Description:" field in 'apt-cache show' as well as in the cache creation itself. We instead assume now that if the stanza has a Description, it will not be the first field as we look out for "\nDescription" to take care of MD5sum as well as (maybe ignored) translated Descriptions embedded in the package stanza. Closes: #712435
2013-06-09fix support for multiple patterns in apt-cache searchDavid Kalnischkies
Patterns can appear in the name as well as in the description, they don't have to match all in the name/description only. Closes: 691453
2013-06-09initialize the whole search array with zeroDavid Kalnischkies
Git-Dch: Ignore
2013-06-09deprecate InstallProtect as a cpu-eating no-opDavid Kalnischkies
In the past packages were flagged "Protected" so that install/ remove markings where issued before the ProblemResolver. Nowadays, the marking methods check if they are allowed to modify the marking of a package instead, so that markings set by FromUser calls are not overwritten anymore by automatic calls which elimates the need for InstallProtect which just eats CPU now. The method itself is left untouched for now in case frontend needs it still for some wierd usecase, but they should be eliminated.
2013-06-09remove -ldl from cdrom and -lutil from apt-get linkageDavid Kalnischkies
Building src:apt shows: dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/apt/usr/lib/apt/methods/cdrom was not linked against libdl.so.2 (it uses none of the library's symbols) dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/apt/usr/bin/apt-get was not linked against libutil.so.1 (it uses none of the library's symbols)
2013-05-22cmdline/apt-key: Accept nonexistent --keyring file with adv as wellJohan Kiviniemi
2013-05-22cmdline/apt-key: Create new keyrings with mode 0644 instead of 0600Johan Kiviniemi
2013-04-08merged bundle from davidMichael Vogt
2013-03-25merge patch from Daniel HartwigMichael Vogt
2013-03-10various simple changes to fix cppcheck warningsDavid Kalnischkies
2013-01-14ensure sha512 is really used when available (thanks to Tyler Hicks )Michael Vogt
2012-11-09* cmdline/apt-get.cc:David Kalnischkies
- do not call Mark{Install,Delete} from the autoremove code with the FromUser bit set to avoid modifying the auto-installed bit
2012-10-20adds a comment for Translators to the 'do as I say' prompt toDavid Kalnischkies
prevent problems like #691024 in new translations
2012-09-26* cmdline/apt-cache.cc:David Kalnischkies
- print versioned dependency relations in (r)depends if the option APT::Cache::ShowVersion is true (default: false) as discussed in #218995 to help debian-cd fixing #687949. Thanks to Sam Lidder for initial patch and Steve McIntyre for nagging and testing!
2012-08-06disable the display of the error messages for DoInstall if DoBuildDepDavid Kalnischkies
is calling the helper (enabled by enforcing failure reporting)
2012-08-05ensure that the right architecture is used for cross-dependencies inDavid Kalnischkies
cases we have to choose a provider by defaulting on host-arch instead of build-arch
2012-08-04improve the check for purely virtuals as provided packages aren'tDavid Kalnischkies
purely virtual and shouldn't error out cause of that
2012-08-04* cmdline/apt-get.cc:David Kalnischkies
- error out on (unsatisfiable) build-deps on purly virtual packages instead of ignoring these dependencies; thanks to Johannes Schauer for the detailed report! (Closes: #683786)
2012-07-04* cmdline/apt-mark.cc:David Kalnischkies
- arch:all packages are treated as arch:native packages, but dpkg expects pkg:all for selections, so use the arch of the installed version instead of the package structure if possible. Thanks to Stepan Golosunov for the report! (Closes: #680041)
2012-06-27fix two simple spelling issues found by Christian Perrier,David Kalnischkies
updating all po's, but as it is a simple transformation no re-call and instead deal with them on merge
2012-06-18* cmdline/apt-get.cc:David Kalnischkies
- print a friendly message in 'download' if a package can't be downloaded (Closes: #677887)
2012-06-11merged from donkultMichael Vogt
2012-06-11check build-dep candidate if install is forbiddenDavid Kalnischkies
2012-06-10* cmdline/apt-get.cc:Thibaut Girka
- complain correctly about :any build-dep on M-A:none packages
2012-06-10show 'bzr branch' as 'bzr get' is deprecated (LP: #1011032)David Kalnischkies
2012-06-10* cmdline/apt-get.cc:Daniel Hartwig
- print URIs for all changelogs in case of --print-uris, thanks to Daniel Hartwig for the patch! (Closes: #674897)
2012-06-06* cmdline/apt-key:Michael Vogt
- do not hardcode /etc but use Dir::Etc instead
2012-05-24* cmdline/apt-get.cc:David Kalnischkies
- do not show 'list of broken packages' header if no package is broken as it happens e.g. for external resolver errors