summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJay Freeman (saurik) <saurik@saurik.com>2010-03-17 07:47:44 +0000
committerJay Freeman (saurik) <saurik@saurik.com>2010-09-30 07:13:59 +0000
commitb2d2f219c262ab5d8f233c9dfa97a3ac9775ad64 (patch)
treead29fd416199df6495b2d93eb36487f67677adb3
parente59669fd4c835122cb849fd7cd2d9bfa7c236a9b (diff)
Committing final workaround for the tiny iframe of doom problem.
-rw-r--r--Cydia.app/package.html20
-rw-r--r--Cydia.app/package.js26
2 files changed, 9 insertions, 37 deletions
diff --git a/Cydia.app/package.html b/Cydia.app/package.html
index 5bd2f4c..7a73701 100644
--- a/Cydia.app/package.html
+++ b/Cydia.app/package.html
@@ -9,20 +9,6 @@
<script type="text/javascript" src="localize.js"></script>
<base target="_blank"/>
-<script type="text/javascript">
- var onframe = function(id, name) {
- var node = document.getElementById(id);
- var frame = window.frames[name];
-
- try {
- node.height = frame.document.body.scrollHeight;
- } catch (e) {
- node.height = 370;
- node.width = 320;
- }
- };
-</script>
-
<!--script type="text/javascript">
var count = -1;
var loaded = function() {
@@ -204,6 +190,12 @@
#rating-done {
display: none;
}
+
+ #depiction-src,
+ #notice-src {
+ height: 1px;
+ width: 320px;
+ }
</style>
</head><body class="pinstripe">
<dialog><panel>
diff --git a/Cydia.app/package.js b/Cydia.app/package.js
index 6ec06cf..104bd8c 100644
--- a/Cydia.app/package.js
+++ b/Cydia.app/package.js
@@ -78,16 +78,7 @@ var special_ = function () {
if (typeof value.notice == "undefined")
$(".notice").addClass("deleted");
else
- $("#notice-src")[0].outerHTML = '<iframe' +
- ' class="notice"' +
- ' id="notice-src"' +
- ' frameborder="0"' +
- ' width="320"' +
- ' height="0"' +
- ' target="_top"' +
- ' src="' + $.xml(value.notice) + '"' +
- ' onload="onframe(' + "'notice-src', 'notice'" + ')"' +
- '></iframe>';
+ $("#notice-src").src(value.notice);
if (typeof value.rating == "undefined")
$(".rating").addClass("deleted");
@@ -210,17 +201,7 @@ var special_ = function () {
$(".depiction").addClass("deleted");
else {
$(".description").addClass("deleted");
-
- $("#depiction-src")[0].outerHTML = '<iframe' +
- ' class="depiction"' +
- ' id="depiction-src"' +
- ' frameborder="0"' +
- ' width="320"' +
- ' height="0"' +
- ' target="_top"' +
- ' src="' + $.xml(depiction) + '"' +
- ' onload="onframe(' + "'depiction-src', 'depiction'" + ')"' +
- '></iframe>';
+ $("#depiction-src").src(depiction);
}
var description = package.longDescription;
@@ -327,7 +308,6 @@ var special = function () {
' width="320"' +
' height="0"' +
' target="_top"' +
- ' onload="onframe(' + "'notice-src', 'notice'" + ')"' +
'></iframe>';
var depiction = $("#depiction-src");
@@ -339,7 +319,7 @@ var special = function () {
' width="320"' +
' height="0"' +
' target="_top"' +
- ' onload="onframe(' + "'depiction-src', 'depiction'" + ')"' +
+ ' onload_="loaded()"' +
'></iframe>';
special_();