summaryrefslogtreecommitdiff
path: root/apt-pkg/contrib/configuration.cc
diff options
context:
space:
mode:
authorDavid Kalnischkies <david@kalnischkies.de>2019-11-27 12:10:31 +0100
committerDavid Kalnischkies <david@kalnischkies.de>2019-11-27 22:00:43 +0100
commit1690c3f87ae45a41e8d3e09bf0b1021c008460b9 (patch)
tree6b95d5a10f07be7e28188f9b0dcba8b08265701d /apt-pkg/contrib/configuration.cc
parent62bfe5b6ca3ccfba6313d3f9ab4cb75a24a5557a (diff)
Remove failed trusted signature instead of index on IMS hit
While passing the combi Release and Release.gpg to the gpgv method for verification the filename of Release is placed where usually Release.gpg is assumed in the rest of the code. The "usual" cases like passing verification and failing verification ending in an error are taking care of this, but the code path dealing with a failed verification, but ignoring said failure (e.g. due to trusted=yes) was not which results in the wrong file being removed later on (in case the index happens to be unmodified since the last update call) leading us into the abyss of strange failures (fixed in the previous commit) were nothing should have changed. This is not a security issue in this form as the repository needs to fail verification & the user forcing apt to ignore the failure and carry on anyhow. It does show however how complicated the code and its various interconnected paths can become. Reported-By: Val "pinkieval" Lorentz on IRC
Diffstat (limited to 'apt-pkg/contrib/configuration.cc')
0 files changed, 0 insertions, 0 deletions