summaryrefslogtreecommitdiff
path: root/methods
diff options
context:
space:
mode:
authorJulian Andres Klode <jak@debian.org>2017-06-30 11:02:54 +0200
committerJulian Andres Klode <jak@debian.org>2017-09-13 18:20:37 +0200
commit6636ec6d45a2da21faf2c004faba346056a52039 (patch)
tree4b023b0ec46f8d88439c1fec572c8cfd50b36239 /methods
parent7bb1078178fdab4bf28a7973b35ca2b37f5eb484 (diff)
Reset failure reason when connection was successful
When APT was trying multiple addresses, any later error somewhere else would be reported with ConnectionRefused or ConnectionTimedOut as the FailReason because that was set by early connect attempts. This causes APT to handle the failures differently, leading to some weirdly breaking test cases (like the changed one). Add debugging to the previously failing test case so we can find out when something goes wrong there again. (cherry picked from commit d3a70c3e5ae68a0e5a3d4667dd1d0fc0887e6263)
Diffstat (limited to 'methods')
-rw-r--r--methods/connect.cc4
1 files changed, 3 insertions, 1 deletions
diff --git a/methods/connect.cc b/methods/connect.cc
index 311fb1af6..3df8baa24 100644
--- a/methods/connect.cc
+++ b/methods/connect.cc
@@ -129,7 +129,9 @@ static bool DoConnect(struct addrinfo *Addr,std::string Host,
return _error->Errno("connect",_("Could not connect to %s:%s (%s)."),Host.c_str(),
Service,Name);
}
-
+
+ Owner->SetFailReason("");
+
return true;
}
/*}}}*/