summaryrefslogtreecommitdiff
path: root/methods
diff options
context:
space:
mode:
authorJulian Andres Klode <julian.klode@canonical.com>2019-04-30 12:07:07 +0200
committerJulian Andres Klode <julian.klode@canonical.com>2019-04-30 17:43:31 +0200
commitb52c6552c44fcb997b0db9f5e9f17b4674dd5359 (patch)
tree711f7259a65f5b658cb5ad4798323c2226cfb7c2 /methods
parent4fa03143eee3776e2fa8fbd59d3cbaea40be0871 (diff)
Add 'explicit' to most single argument constructors
This prevents implicit conversions that we do not want, such as having a FileFd* being converted to a debListParser. Two cases are not yet handled because they require changes in code using them: 1. The classes in hashes.h 2. The URI class - this one is used quite a lot
Diffstat (limited to 'methods')
-rw-r--r--methods/mirror.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/methods/mirror.cc b/methods/mirror.cc
index add9f0875..dcf4cbd13 100644
--- a/methods/mirror.cc
+++ b/methods/mirror.cc
@@ -97,7 +97,7 @@ class MirrorMethod : public aptMethod /*{{{*/
void DealWithPendingItems(std::vector<std::string> const &baseuris, MirrorListInfo const &info, FetchItem *const Itm, std::function<void()> handler);
public:
- MirrorMethod(std::string &&pProg) : aptMethod(std::move(pProg), "2.0", SingleInstance | Pipeline | SendConfig | AuxRequests), genrng(clock())
+ explicit MirrorMethod(std::string &&pProg) : aptMethod(std::move(pProg), "2.0", SingleInstance | Pipeline | SendConfig | AuxRequests), genrng(clock())
{
SeccompFlags = aptMethod::BASE | aptMethod::DIRECTORY;
}